Il 12/04/2018 06:19, Pirate Praveen ha scritto: > > > On April 12, 2018 2:48:32 AM GMT+05:30, Paolo Greppi <paolo.gre...@libpf.com> > wrote: >> Normally you'd expect to fix bugs with a new version, in this case >> while trying to update node-define-property 1.0.0-1 -> 2.0.2 the >> failing tests actually increased from 1 to 4. >> >> What puzzled me was that no tests fail on upstream's CI (travis), which >> also tests nodejs version 8. >> >> Turns out that we have upgraded node-is-descriptor to version 2.0.0, >> but the npm registry only has 1.0.2. >> >> I have forwarded the issue upstream, and I expect upstream to answer >> that define-property correctly pins the major version of is-descriptor >> with ^1.0.2 (https://docs.npmjs.com/misc/semver), stating that it won't >> work with 2.x. >> >> ^1.0.2 should be translated with >= 1.0.2 && < 2.0.0 but we can't >> encode that in debian/control. >> >> So how can we check reverse dependencies for this type of issues in the >> future ? >> >> Paolo > > build-and-upload script from ruby-team/meta can help if we have enabled > tests. If we used that, then is-descriptor 1.0 -> 2.0 update would notify the > failure before upload. But its likely we added is-descriptor 2.0 directly. > > The best choice is upstream updating their dependency. Second choice is we > update and send merge request. > > As a worse case, we can downgrade node-is-descriptor to 1.0 if we have no > other reverse dependency or embed 1.0 in node-define-property. >
Upstream closed the issue I reported: https://github.com/jonschlinkert/define-property/issues/3 so that rules out option #1. I have checked and in Debian we have no other dependent than node-define-property: apt-cache rdepends node-is-descriptor node-is-descriptor Reverse Depends: node-define-property whereas on npm registry there are 5 dependents listed: - react-native-handcheque-engine - dk_2018_1_1 - @ngxvoice/ngx-voicelistner - define-property - vue-size-tracker none of which has ITP/RFP. So I'd propose we go straight for option #3 (downgrade node-is-descriptor to 1.0). Can you do that please ? Paolo