Source: donkey
Version: 1.2.0-1
Severity: serious
Tags: patch

The donkey upstraem source has two modes of running its tests:
using a pseudo-tty driver, and using tmux in control mode.
However, tmux 3.x has a regression (that is probably worth reporting
a separate bug for) that, among other things such as my need for
an actual tmux control mode library, led to me writing up the (still
raw and quite unfinished) https://gitlab.com/ppentchev/tmux-ctlmode
project. That part is not really pertinent to the Debian package of
donkey though, since I have not yet finished or packaged tmux-ctlmode
for Debian so donkey can use it to build.

A quick workaround for e.g.

  https://ci.debian.net/data/autopkgtest/testing/i386/d/donkey/13206643/log.gz

...would be to use the donkey source build system's "pty" test runner:

diff --git a/debian/rules b/debian/rules
index 8fe8f13..d16747a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -20,7 +20,7 @@ override_dh_auto_build:
        dh_auto_build -D src
 
 override_dh_auto_test:
-       dh_auto_test -D src
+       dh_auto_test -D src -- TEST_PROCESS_DRIVER=pty
 
 override_dh_auto_clean:
        dh_auto_clean -D src
diff --git a/debian/tests/control b/debian/tests/control
index d544f0c..3650d6e 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,4 +1,4 @@
-Test-Command: env TEST_PROG=/usr/bin/donkey python3 src/test-donkey.py
+Test-Command: env TEST_PROCESS_DRIVER=pty TEST_PROG=/usr/bin/donkey python3 
src/test-donkey.py
 Depends: @, python3, python3-ddt, python3-six, tmux
 Restrictions: allow-stderr
 Features: test-name=upstream

This should be enough to get the donkey package up and building again.

G'luck,
Peter


-- System Information:
Debian Release: 11.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-7-amd64 (SMP w/8 CPU threads)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Attachment: signature.asc
Description: PGP signature

Reply via email to