Control: tags -1 moreinfo

Hi!

On Tue, 2018-05-29 at 22:39:41 +0900, Norbert Preining wrote:
> Package: dpkg-dev
> Version: 1.19.0.5
> Severity: important

> it is a bit disturbing that patches I use contain in the header:
> 
>  ...
>  8 files changed, 183 insertions(+), 17 deletions(-)
>  create mode 100755 texk/web2c/pdftexdir/expanded.test
>  create mode 100644 texk/web2c/pdftexdir/tests/expanded.tex
>  create mode 100644 texk/web2c/pdftexdir/tests/expanded.txt
> 
> but the permissions are not correctly mentioned.

Mentioned where? Do you mean the patch does not contain the permission
information any longer in the diff header? Such as:

,---
diff --git i/file w/file
old mode 100644
new mode 100755
`---

? If so I'd assume you have refreshed the patch with quilt, which uses
diff underneath which does not support generating git formatted diffs.

> Either dpkg-source or quilt needs a fix, in one way or another.
> Supporting setting permissions via a patch file is strongly
> advised.

git formatter patches, is something that actually accidentally slipped
in when patch gained support for it, but the rest of our toolchain does
not, so you should expect several rough edges around this. :/

Thanks,
Guillem

Reply via email to