Your message dated Tue, 29 Jan 2019 10:35:08 +0100
with message-id <[email protected]>
and subject line Re: Bug#900361: dpkg-source: support permissions of quilt
created files
has caused the Debian Bug report #900361,
regarding dpkg-source: support permissions of quilt created files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
900361: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900361
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dpkg-dev
Version: 1.19.0.5
Severity: important
Dear dpkg team,
it is a bit disturbing that patches I use contain in the header:
...
8 files changed, 183 insertions(+), 17 deletions(-)
create mode 100755 texk/web2c/pdftexdir/expanded.test
create mode 100644 texk/web2c/pdftexdir/tests/expanded.tex
create mode 100644 texk/web2c/pdftexdir/tests/expanded.txt
but the permissions are not correctly mentioned.
Either dpkg-source or quilt needs a fix, in one way or another.
Supporting setting permissions via a patch file is strongly
advised.
Thanks
Norbert
-- System Information:
Debian Release: buster/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.16.11 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages dpkg-dev depends on:
ii binutils 2.30-20
ii bzip2 1.0.6-8.1
ii libdpkg-perl 1.19.0.5
ii make 4.2.1-1
ii patch 2.7.6-2
ii perl 5.26.2-5
ii tar 1.30+dfsg-2
ii xz-utils 5.2.2-1.3
Versions of packages dpkg-dev recommends:
ii build-essential 12.5
ii clang-3.8 [c-compiler] 1:3.8.1-27
ii clang-4.0 [c-compiler] 1:4.0.1-10+b1
ii fakeroot 1.22-2
ii gcc [c-compiler] 4:7.3.0-3
ii gcc-5 [c-compiler] 5.5.0-12
ii gcc-6 [c-compiler] 6.4.0-17
ii gcc-7 [c-compiler] 7.3.0-19
ii gcc-8 [c-compiler] 8.1.0-3
ii gnupg 2.2.7-1
ii gnupg2 2.2.7-1
ii gpgv 2.2.7-1
ii libalgorithm-merge-perl 0.08-3
Versions of packages dpkg-dev suggests:
ii debian-keyring 2018.03.24
-- no debconf information
--- End Message ---
--- Begin Message ---
Hi!
On Thu, 2018-06-07 at 14:17:23 +0200, Guillem Jover wrote:
> Control: tags -1 moreinfo
> On Tue, 2018-05-29 at 22:39:41 +0900, Norbert Preining wrote:
> > Package: dpkg-dev
> > Version: 1.19.0.5
> > Severity: important
>
> > it is a bit disturbing that patches I use contain in the header:
> >
> > ...
> > 8 files changed, 183 insertions(+), 17 deletions(-)
> > create mode 100755 texk/web2c/pdftexdir/expanded.test
> > create mode 100644 texk/web2c/pdftexdir/tests/expanded.tex
> > create mode 100644 texk/web2c/pdftexdir/tests/expanded.txt
> >
> > but the permissions are not correctly mentioned.
>
> Mentioned where? Do you mean the patch does not contain the permission
> information any longer in the diff header? Such as:
>
> ,---
> diff --git i/file w/file
> old mode 100644
> new mode 100755
> `---
>
> ? If so I'd assume you have refreshed the patch with quilt, which uses
> diff underneath which does not support generating git formatted diffs.
>
> > Either dpkg-source or quilt needs a fix, in one way or another.
> > Supporting setting permissions via a patch file is strongly
> > advised.
>
> git formatter patches, is something that actually accidentally slipped
> in when patch gained support for it, but the rest of our toolchain does
> not, so you should expect several rough edges around this. :/
Given there's been no answer, I'll assume the affected patches got
refreshed with quilt and the git-formatted metadata got thus dropped.
This would then not be a bug in dpkg, and I don't think in quilt/patch
either, as it cannot know whether these permissions need to be kept or
not. If you are managing git patches, ideally you'd rebase them from
git or similar?
If this was about something else, please feel free to reopen.
Thanks,
Guillem
--- End Message ---
