Control: reassign -1 libdpkg-perl 1.19.2

Hi!

On Tue, 2018-11-06 at 08:03:14 -0500, Jeremy Bicha wrote:
> Package: libdpkg-dev
> Version: 1.19.2
> Tags: patch

> Please see the patch in my follow up email.

Thanks for providing a patch!

> Ubuntu uses pkgbinarymangler by default to do several different tasks
> to packages.
> 
> Test Case
> -------------
> I'd like to disable the png optimization when using sbuild to build
> Ubuntu packages to speed up local test builds.
> 
> So I add this to my ~/.sbuildrc
> $ENV{'NO_PNG_PKG_MANGLE'} = '1';

> Currently, dpkg doesn't allow that environment variable to be passed
> through so I would have to make this change in debian/rules directly.
> I don't want to do that since it's fine for the official builds to
> have that png optimization done.

dpkg-dev does no environment cleansing, that's sbuild. I think what
you want is to modify its $environment_filter variable in .sbuildrc.

So, while the whitelist is indeed intended to list this kind of
variables that might end up affecting the resulting artifacts, I'm
not comfortable adding support for these, as it feels it would
legitimate them, when these tools seem to me to be clever hacks that
would ideally need to be properly integrated in the correct layers.

So given all the above, I'm inclined towards closing this report.

Thanks,
Guillem

Reply via email to