Your message dated Tue, 29 Jan 2019 10:41:05 +0100 with message-id <[email protected]> and subject line Re: Bug#913056: libdpkg-dev: whitelist Ubuntu mangling environment variables has caused the Debian Bug report #913056, regarding libdpkg-dev: whitelist Ubuntu mangling environment variables to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 913056: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913056 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: libdpkg-dev Version: 1.19.2 Tags: patch Please see the patch in my follow up email. Ubuntu uses pkgbinarymangler by default to do several different tasks to packages. Test Case ------------- I'd like to disable the png optimization when using sbuild to build Ubuntu packages to speed up local test builds. So I add this to my ~/.sbuildrc $ENV{'NO_PNG_PKG_MANGLE'} = '1'; Currently, dpkg doesn't allow that environment variable to be passed through so I would have to make this change in debian/rules directly. I don't want to do that since it's fine for the official builds to have that png optimization done. Other Info ------------ This is partially documented at http://manpages.ubuntu.com/manpages/pkgstriptranslations http://manpages.ubuntu.com/manpages/pkgmaintainermangler Unfortunately, there is no manpage provided for pkgstripfiles which is the source of the two specific environment variables: NO_PNG_PKG_MANGLE & NO_DOC_PKG_MANGLE Thanks, Jeremy Bicha
--- End Message ---
--- Begin Message ---Hi! On Tue, 2018-11-06 at 10:59:47 -0500, Jeremy Bicha wrote: > On Tue, Nov 6, 2018 at 10:49 AM Guillem Jover <[email protected]> wrote: > > dpkg-dev does no environment cleansing, that's sbuild. I think what > > you want is to modify its $environment_filter variable in .sbuildrc. > > It's a bit annoying to need to set 2 lines instead of 1 in my sbuildrc > but it's not a big problem. I guess I can ask the sbuild maintainers > to expand their whitelist instead. > > $environment_filter = [Dpkg::Build::Info::get_build_env_whitelist(), > 'NO_PNG_PKG_MANGLE']; > $ENV{'NO_PNG_PKG_MANGLE'} = '1'; > > based on the docs in > https://manpages.debian.org/unstable/sbuild.conf#Core_options Right. > > So, while the whitelist is indeed intended to list this kind of > > variables that might end up affecting the resulting artifacts, I'm > > not comfortable adding support for these, as it feels it would > > legitimate them, when these tools seem to me to be clever hacks that > > would ideally need to be properly integrated in the correct layers. > > So given all the above, I'm inclined towards closing this report. Not sure whether you asked, so I'll close this now, but obviously feel free to reopen and reassign otherwise! Thanks, Guillem
--- End Message ---
