Your message dated Sun, 24 Feb 2019 02:28:39 +0100 with message-id <[email protected]> and subject line Re: Bug#485330: Non-unified patches and dpkg source format ‘3.0 (quilt)’. has caused the Debian Bug report #485330, regarding dpkg: patch apply problem: line after --- isn't as expected in diff to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 485330: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485330 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: dpkg Version: 1.16.3 Severity: normal Error message: dpkg-source: error: line after --- isn't as expected in diff `readline5.git/debian/patches/02-rl-001.patch' (line 27) For patches: 25 *** ../readline-5.2/display.c Thu Sep 14 14:20:12 2006 26 --- ./display.c Mon Nov 13 17:55:57 2006 27 *************** 28 *** 2381,2384 **** 29 --- 2409,2414 ---- 30 if (end <= start) These patches work fine with quilt(1) and patch(1).From: Matthias Klose <[email protected]> Subject: In some cases, code that is intended to be used in the presence of multibyte characters is called when no such characters are present, leading to incorrect display position calculations and incorrect redisplay. . READLINE PATCH REPORT ===================== . Readline-Release: 5.2 Patch-ID: readline52-001 . Bug-Reported-by: [email protected] Bug-Reference-ID: <[email protected]> Bug-Reference-URL: http://lists.gnu.org/archive/html/bug-bash/2006-11/msg00017.html http://lists.gnu.org/archive/html/bug-bash/2006-11/msg00016.html . Bug-Description: . In some cases, code that is intended to be used in the presence of multibyte characters is called when no such characters are present, leading to incorrect display position calculations and incorrect redisplay. *** ../readline-5.2/display.c Thu Sep 14 14:20:12 2006 --- ./display.c Mon Nov 13 17:55:57 2006 *************** *** 2381,2384 **** --- 2409,2414 ---- if (end <= start) return 0; + if (MB_CUR_MAX == 1 || rl_byte_oriented) + return (end - start); memset (&ps, 0, sizeof (mbstate_t));
--- End Message ---
--- Begin Message ---Control: tag -1 wontfix Hi! On Sun, 2009-08-09 at 18:04:34 +0200, Raphael Hertzog wrote: > retitle 485330 Allow context diff in debian/patches/ in 3.0 (quilt) format > thanks I'd rather not accept more patch formats TBH. Even less given the amount of security holes we've had just through patch itself. Having a single format (well including git formatted patches as extensions to the unified format) looks like a rather good property to me. And given that we have survived until now w/o the need for context diffs, and that it's pretty trivial to convert formats, I'm just going to mark this as wontfix and close it. Thanks, Guillem
--- End Message ---
