Your message dated Sun, 24 Feb 2019 02:28:39 +0100 with message-id <[email protected]> and subject line Re: Bug#485330: Non-unified patches and dpkg source format ‘3.0 (quilt)’. has caused the Debian Bug report #485330, regarding Allow context diff in debian/patches/ in 3.0 (quilt) format to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 485330: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485330 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: emboss Version: 5.0.0-7 Severity: wishlist Usertags: 3.0-quilt-by-default To prepare a possible switch to the new source package format "3.0 (quilt)" [1], I converted all source packages and tried to rebuild them. Unfortunately, emboss failed, you can try yourself with those commands (and dpkg-dev >= 1.14.19 [2]) : $ apt-get source emboss $ sed -i -e '/^Source:/ aFormat: 3.0 (quilt)' emboss-5.0.0/debian/control $ dpkg-source -b emboss-5.0.0 $ dpkg-source -x emboss_5.0.0-7.dsc $ cd emboss-5.0.0 && debuild -us -uc In this process, if the .diff.gz contains changes to upstream files, dpkg-source will have created a corresponding patch in debian/patches/debian-changes-5.0.0-7 and will have registered that patch in a quilt series (debian/patches/series, it is created if needed). All the patches listed in the "series" file are applied directly during the extraction (dpkg-source -x). quilt itself is used if available (and will thus lead to the creation of the .pc directory), otherwise dpkg-source applies the patches by itself. For more information about the new source package format see the manual page dpkg-source(1). In the case of emboss, the patch emboss-5.0.0/debian/patches/patch-1-9 is not in unified diff format. Please convert it. quilt refresh can do this for you. As a side note, you must also pay attention to the following points in your quilt usage to guarantee compatibility with the new source package format: - all your patches must be applicable with the "-p1" option of patch (and you shouldn't use options in the series file to override this) - the patches must be in debian/patches/ together with the "series" file (you can use QUILT_PATCHES=debian/patches if needed) - you should not override QUILT_PC to change the location of quilt's internal directory (".pc" by default) - your clean target must work even if the patches are already applied - your build target must work with patches applied even if the clean target is supposed to unapply them (because dpkg-source -b might have applied them back) Cheers, [1] http://lists.debian.org/debian-devel-announce/2008/04/msg00004.html [2] the upcoming dpkg-dev 1.14.20 is more tolerant with patches, you can grab it here if you want to try with that version: http://people.debian.org/~hertzog/packages/dpkg-dev_1.14.20_all.deb -- Raphael Hertzog
--- End Message ---
--- Begin Message ---Control: tag -1 wontfix Hi! On Sun, 2009-08-09 at 18:04:34 +0200, Raphael Hertzog wrote: > retitle 485330 Allow context diff in debian/patches/ in 3.0 (quilt) format > thanks I'd rather not accept more patch formats TBH. Even less given the amount of security holes we've had just through patch itself. Having a single format (well including git formatted patches as extensions to the unified format) looks like a rather good property to me. And given that we have survived until now w/o the need for context diffs, and that it's pretty trivial to convert formats, I'm just going to mark this as wontfix and close it. Thanks, Guillem
--- End Message ---
