The following commit has been merged in the master branch:
commit 9581f11d5efb591cd95baeae38054ab37d30df8c
Author: Guillem Jover <[email protected]>
Date: Wed Jan 9 19:54:47 2013 +0100
dpkg-scansources: Use a foreach loop instead of a void map
Fixes BuiltinFunctions::ProhibitVoidMap.
diff --git a/scripts/dpkg-scansources.pl b/scripts/dpkg-scansources.pl
index 9058216..671863b 100755
--- a/scripts/dpkg-scansources.pl
+++ b/scripts/dpkg-scansources.pl
@@ -338,12 +338,10 @@ sub main {
close $find_fh or error(close_msg, 'find');
if (@out) {
- map {
- $_->output(\*STDOUT);
+ foreach my $dsc (sort { $a->{Package} cmp $b->{Package} } @out) {
+ $dsc->output(\*STDOUT);
print "\n";
- } sort {
- $a->{Package} cmp $b->{Package}
- } @out;
+ }
}
return 0;
diff --git a/test/100_critic.t b/test/100_critic.t
index eaa8ff4..4f86729 100644
--- a/test/100_critic.t
+++ b/test/100_critic.t
@@ -41,6 +41,7 @@ my @policies = qw(
BuiltinFunctions::ProhibitUniversalCan
BuiltinFunctions::ProhibitUniversalIsa
BuiltinFunctions::ProhibitVoidGrep
+ BuiltinFunctions::ProhibitVoidMap
BuiltinFunctions::RequireGlobFunction
BuiltinFunctions::RequireSimpleSortBlock
ClassHierarchies::ProhibitAutoloading
--
dpkg's main repository
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
