The following commit has been merged in the master branch:
commit 485f640303d899d8f8af23ee2422a635bef56604
Author: Guillem Jover <[email protected]>
Date: Tue Jan 1 14:38:02 2013 +0100
Dpkg::Version: Use the block form for the map function
Fixes BuiltinFunctions::RequireBlockMap.
diff --git a/scripts/Dpkg/Version.pm b/scripts/Dpkg/Version.pm
index 3f28faf..8ee1964 100644
--- a/scripts/Dpkg/Version.pm
+++ b/scripts/Dpkg/Version.pm
@@ -326,8 +326,8 @@ sub _version_order {
}
sub version_compare_string($$) {
- my @a = map(_version_order($_), split(//, shift));
- my @b = map(_version_order($_), split(//, shift));
+ my @a = map { _version_order($_) } split(//, shift);
+ my @b = map { _version_order($_) } split(//, shift);
while (1) {
my ($a, $b) = (shift @a, shift @b);
return 0 if not defined($a) and not defined($b);
diff --git a/test/100_critic.t b/test/100_critic.t
index ad3f87f..6d245d5 100644
--- a/test/100_critic.t
+++ b/test/100_critic.t
@@ -43,6 +43,7 @@ my @policies = qw(
BuiltinFunctions::ProhibitUniversalIsa
BuiltinFunctions::ProhibitVoidGrep
BuiltinFunctions::ProhibitVoidMap
+ BuiltinFunctions::RequireBlockMap
BuiltinFunctions::RequireGlobFunction
BuiltinFunctions::RequireSimpleSortBlock
ClassHierarchies::ProhibitAutoloading
--
dpkg's main repository
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
