On 12/10/09, Darren Salt <[email protected]> wrote:
> I demand that Alan Jenkins may or may not have written...
>
> [snip]
>> Check for the EeePC 701 using DMI.  If met, then disable writes to the
>> "cpufv" sysfs attribute and log an explanatory message.
>
> Selecting EEEPC_LAPTOP needs to select DMI. If DMI=n, dmi_get_system_info()
> will be inlined and will return NULL.

Ah, thanks for pointing this out.  I've sent a new version with a NULL
check, so we don't crash.

I'm not sure about selecting DMI, as nothing else seems to do so.  You
can only disable it if CONFIG_EMBEDDED=y.  And I think the help text
for CONFIG_DMI  is sufficiently scary - it effectively says that you
need to check against every single DMI blacklist in the kernel,
without telling you how :).

Alan

_______________________________________________
Debian-eeepc-devel mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/debian-eeepc-devel

Reply via email to