On Fri, Dec 11, 2009 at 11:14 PM, Darren Salt <[email protected]> wrote: > I demand that Alan Jenkins may or may not have written... > >> On 12/10/09, Darren Salt <[email protected]> wrote: >>> I demand that Alan Jenkins may or may not have written... >>> [snip] >>>> Check for the EeePC 701 using DMI. If met, then disable writes to the >>>> "cpufv" sysfs attribute and log an explanatory message. >>> Selecting EEEPC_LAPTOP needs to select DMI. If DMI=n, >>> dmi_get_system_info() will be inlined and will return NULL. > >> Ah, thanks for pointing this out. I've sent a new version with a NULL >> check, so we don't crash. > >> I'm not sure about selecting DMI, as nothing else seems to do so. > > That does appear to be the case, but two items (DMIID and LEDS_CLEVO_MAIL) > *depend* on DMI. The same could be done here: make the cpufv support optional > by adding EEEPC_LAPTOP_CPUFV and having it depend on EEEPC_LAPTOP && DMI. >
I think it's better to keep it simple. If it's ok for everyone here, I'll merge it to acpi4asus tree and send it next week to linux-acpi. >> You can only disable it if CONFIG_EMBEDDED=y. And I think the help text >> for CONFIG_DMI is sufficiently scary - it effectively says that you need >> to check against every single DMI blacklist in the kernel, without telling >> you how :). > > Well, maybe when there's One True Way of implementing these blacklists... ;-) > > -- > | Darren Salt | linux at youmustbejoking | nr. Ashington, | Doon > | using Debian GNU/Linux | or ds ,demon,co,uk | Northumberland | Army > | + http://www.xine-project.org/ > > The greatest remedy for anger is delay. > -- Corentin Chary http://xf.iksaif.net _______________________________________________ Debian-eeepc-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/debian-eeepc-devel
