Makes sense. This is why I asked instead of just doing the work! I'll stick with my patch for now and if it's something that we run into elsewhere we can re-evaluate.
Stephen On Tue, Jan 8, 2019 at 1:08 AM Michael Stapelberg <[email protected]> wrote: > > I’m generally in favor of only adding knobs once a substantial number of > packages benefit from them. > > On Tue, Jan 8, 2019 at 4:47 AM Stephen Gelman <[email protected]> wrote: >> >> Hi, >> >> Currently, with dh-golang, the only configuration option for running “go >> generate” is DH_GOLANG_GO_GENERATE which is all or nothing. With git-lfs, >> one of the “go generate” commands it runs is windows-specific so I had to >> patch it out >> (https://salsa.debian.org/go-team/packages/git-lfs/blob/8a4bad783a43ee05c144b96f44671eec62324a77/debian/patches/remove-unnecessary-go-generate.patch). >> I was thinking of adding support in dh-golang to only run “go generate” >> for certain files but before I put in the effort I wanted to get people’s >> thoughts on it. Do you all think that would be useful? If git-lfs is the >> only package that requires it I’m fine with just keeping my patch but I >> doubt it’s the only case where the functionality would be useful. >> Alternatively it could be configurable which “go generate” commands should >> be excluded, but I think that’s generally less useful. What do you all >> think? >> >> Thanks! >> >> Stephen > > > > -- > Best regards, > Michael
