I opened an issue upstream [1] and they have already prepared a fix for it.  
Thanks for the great suggestion!

Stephen

[1] https://github.com/git-lfs/git-lfs/issues/3473

> On Jan 9, 2019, at 11:09 AM, Stephen Gelman <[email protected]> wrote:
> 
> Oh, that's a good question.  I can look into that more and file an upstream 
> PR.
> 
> Stephen
> 
> On Wed, Jan 9, 2019 at 9:26 AM Shengjing Zhu <[email protected]> wrote:
>> 
>> On Tue, Jan 8, 2019 at 11:47 AM Stephen Gelman <[email protected]> wrote:
>>> 
>>> Hi,
>>> 
>>> Currently, with dh-golang, the only configuration option for running “go 
>>> generate” is DH_GOLANG_GO_GENERATE which is all or nothing.  With git-lfs, 
>>> one of the “go generate” commands it runs is windows-specific
>> 
>> Probably this is bug in upstream, but I haven't digged into the code.
>> 
>> `go generate` should respect build tags. Why this command is not in
>> file which has `+build windows` tag?
>> 
>> 
>> --
>> Shengjing Zhu

Reply via email to