Vincent Blut <[email protected]> writes:

> Would someone in the team be willing to review this new package?
>
> https://salsa.debian.org/go-team/packages/golang-github-jezek-xgb

Looks good to me.  Some nitpicks:

I think you want to add the names from AUTHORS to debian/copyright since
it claims they are authors for copyright purposes.

The file xf86vidmode/xf86vidmode.go says 'This file is automatically
generated from xf86vidmode.xml.', thus I think it should be re-generated
at build-time from source.  I can't find xf86vidmode.xml in the project,
maybe something to ask upstream about.  Same for xf86dri/xf86dri.go and
several other files, grep for 'This file is automatically generated'.

Is 'Archive: GitHub' a standard header for debian/upstream/metadata?  I
didn't know it could replace debian/watch, interesting!

Per debian-policy 3.4.2 I would add the following to debian/control's
"Description:" field:

 .
 This package contains the Go development library.

/Simon

Attachment: signature.asc
Description: PGP signature

Reply via email to