Le 2026-02-06 22:57, Simon Josefsson a écrit : > Vincent Blut <[email protected]> writes: > > > Would someone in the team be willing to review this new package? > > > > https://salsa.debian.org/go-team/packages/golang-github-jezek-xgb > > Looks good to me. Some nitpicks: > > I think you want to add the names from AUTHORS to debian/copyright since > it claims they are authors for copyright purposes.
*nod* Listing them individually is definitely more appropriate than the current "The XGB Authors" copyright notice. > The file xf86vidmode/xf86vidmode.go says 'This file is automatically > generated from xf86vidmode.xml.', thus I think it should be re-generated > at build-time from source. I can't find xf86vidmode.xml in the project, > maybe something to ask upstream about. Same for xf86dri/xf86dri.go and > several other files, grep for 'This file is automatically generated'. Indeed, XCB binding provided by this project are pre-built from the XML-XCB protocol descriptions available there: https://gitlab.freedesktop.org/xorg/proto/xcbproto/-/tree/master/src > Is 'Archive: GitHub' a standard header for debian/upstream/metadata? Could you clarify what you mean by "standard header"? > I didn't know it could replace debian/watch, interesting! I'm not sure this is documented anywhere, but you can see the logic used when uscan does not find any watch file: https://salsa.debian.org/debian/devscripts/-/blob/main/lib/Devscripts/Uscan/FindFiles.pm?ref_type=heads#L155 In a nutshell, it creates a watch file on-the-fly and uses a template based on the value of the "Archive:" field. > Per debian-policy 3.4.2 I would add the following to debian/control's > "Description:" field: > > . > This package contains the Go development library. dh-make-golang appends "(library)" to the synopsis when creating a library package. Is it really usefull to duplicate this information in the long description? https://github.com/Debian/dh-make-golang/blob/master/template.go#L172 > /Simon Thanks for your initial review Simon! Cheers, Vincent
signature.asc
Description: PGP signature
