There is a large difference between upstream 'siso/v1.5.12' git tag and your upstream/latest and debian/latest source content. Did you already consider using upstream git as the source code? Auditing that diff is boring, and I'm not sure it is useful use of our time going forward. Is it possible to build from upstream git instead? The debian/watch, debian/README.source and the versioning doesn't seem entirely consistent, are you using +ds source tarballs or not? There is no Files-Excluded in there either, and I wonder if debian/watch with 'uscan' really do the right thing?
The minified *.js files looks problematic, but maybe that's between you and DFSG Team. Otherwise it looks good, and built for me. I would want to see debian/README.source updated to reflect reality a bit more though, before I feel confident to sponsor an upload -- I'm finding it a bit hard to audit the trail between upstream git and your upstream source code. /Simon Juan <[email protected]> writes: > Hi Simon, Guillem: > > I think I addressed your comments with the latest > changes I committed, including the ones that Nicolas Peugnet did on > the repository. > > > Regarding submitting siso manpage upstream, here it goes the > CL submitted to chromium's Gerrit: > https://chromium-review.googlesource.com/c/build/+/7836640 > > > I appreciate all the feedback, and serve this to notify this should be > ready for a final round of review, or hopefully a sponsored upload :) > > https://salsa.debian.org/mendezr/siso > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051557 > >
signature.asc
Description: PGP signature
