This is the second (and hopefully last) batch of patches to fix references and typos in checks/*.desc files.
There are 9 tiny patches, but I don't know how do you prefer to apply them. Some of the patches have a more detailed commit message, so I have attached the output of `git format-patch' (000*.patch files). However, refs-and-typos.patch is also attached if you prefer to apply all the changes at once. Additionally, there is a reference I'm not sure about. From checks/shared-libs.desc: Tag: shlib-with-executable-bit Info: Shared libraries should be mode 0644. Ref: policy 8.1 Tag: shlib-with-bad-permissions Info: Shared libraries should be mode 0644. Ref: policy 8.1 Policy 8.1 states that "Shared libraries should not be installed executable...", but it doesn't say anything about 0644. So, the first Ref is probably OK, but I'm not sure about the second one. Should it point to 10.9 instead, or there is no need to be so strict?
>From dbd0c99675d076dffa66f64f961c7e03c2274e89 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Wed, 23 Jul 2008 19:40:26 +0200 Subject: [PATCH] Add two new references and fix a typo --- checks/files.desc | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/checks/files.desc b/checks/files.desc index f33fdbc..519b0ed 100644 --- a/checks/files.desc +++ b/checks/files.desc @@ -19,7 +19,7 @@ Type: error Info: The app-defaults files have moved to /etc/X11/app-defaults/. Files in the old directory, /usr/X11R6/lib/X11/app-defaults/, will no longer be used by X. The old directory should not exist in packages at all; - this prevents X from replacing it with a compatability symlink. + this prevents X from replacing it with a compatibility symlink. Ref: policy 11.8.6 Tag: package-installs-font-to-usr-x11r6 @@ -205,6 +205,7 @@ Info: The file is owned by the games group but is not mode 2755. If a game does not have to be setgid games, it should be owned by the root group like any other executable. This executable is either owned by the wrong group or is not setgid when it should be. +Ref: policy 11.11 Tag: non-standard-setuid-executable-perm Type: warning @@ -253,6 +254,7 @@ Type: error Info: The package installs some files into the old <tt>/usr/doc/examples</tt> directory. The new location for examples is <tt>/usr/share/doc/<i>pkg</i>/examples</tt>. +Ref: policy 12.6 Tag: compressed-symlink-with-wrong-ext Type: error -- 1.5.6.3
>From e2be4e8a5cb67217b0405785dfa287e1ed4f9e9a Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Wed, 23 Jul 2008 19:41:18 +0200 Subject: [PATCH] Fix wrong section in reference Debian Policy section 3.10 does not exist, but the --quiet option is mentioned in 3.9. --- checks/infofiles.desc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/checks/infofiles.desc b/checks/infofiles.desc index 07f16c1..f67fc79 100644 --- a/checks/infofiles.desc +++ b/checks/infofiles.desc @@ -60,7 +60,7 @@ Info: The preinst script calls the <tt>install-info</tt> command. Usually, Tag: install-info-not-called-with-quiet-option Type: warning -Ref: policy 3.10 +Ref: policy 3.9 Info: The package installation scripts should avoid producing output which it is unnecessary for the user to see. Policy specifically mentions install-info output as unnecessary. -- 1.5.6.3
>From 7f362baafc924a82b6e316ef9159d7b0d6ef2ce0 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Wed, 23 Jul 2008 19:43:27 +0200 Subject: [PATCH] Fix typo in tag description --- checks/menus.desc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/checks/menus.desc b/checks/menus.desc index c030fe2..6aff4f2 100644 --- a/checks/menus.desc +++ b/checks/menus.desc @@ -253,7 +253,7 @@ Tag: doc-base-abstract-might-contain-extra-leading-whitespaces Type: warning Info: Continuation lines of the Abstract field of doc-base control file should start with only one space unless they are meant to be displayed - verbatim by fontends. + verbatim by frontends. Ref: Debian doc-base Manual section 2.3.2 Tag: doc-base-abstract-field-separator-extra-whitespaces -- 1.5.6.3
>From f225fbd7acffd48b43ded77ff90ca2b7425d10b8 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Mon, 28 Jul 2008 17:41:13 +0200 Subject: [PATCH] Update outdated references to policy --- checks/scripts.desc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/checks/scripts.desc b/checks/scripts.desc index b071a9f..1fffe90 100644 --- a/checks/scripts.desc +++ b/checks/scripts.desc @@ -371,14 +371,14 @@ Info: The maintainer script modifies at least one of the files <tt>/etc/services</tt>, <tt>/etc/protocols</tt>, and <tt>/etc/rpc</tt>, which are managed by the netbase package. Instead of doing this, please file a wishlist bug against netbase to have an appropriate entry added. -Ref: policy 10.7.4 +Ref: policy 11.2 Tag: maintainer-script-modifies-inetd-conf Type: error Info: The maintainer script modifies <tt>/etc/inetd.conf</tt> directly. This file must not be modified directly; instead, use the <tt>update-inetd</tt> script or the <tt>DebianNet.pm</tt> Perl module. -Ref: policy 10.7.4 +Ref: policy 11.2 Tag: install-sgmlcatalog-deprecated Type: error -- 1.5.6.3
>From 7f1b7fb434ab49ccadc1ede4acb8097234fac296 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Tue, 29 Jul 2008 13:08:47 +0200 Subject: [PATCH] Add new reference to policy Required init.d options are explained in the Debian Policy 9.3.2. --- checks/init.d.desc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/checks/init.d.desc b/checks/init.d.desc index a9400ab..efbbae7 100644 --- a/checks/init.d.desc +++ b/checks/init.d.desc @@ -59,6 +59,7 @@ Info: <tt>/etc/init.d</tt> scripts should be marked as conffiles. Tag: init.d-script-does-not-implement-required-option Type: error +Ref: policy 9.3.2 Info: The <tt>/etc/init.d</tt> scripts have to support the following command line arguments: start, stop, restart, force-reload. -- 1.5.6.3
>From 9401f95ff7726e8144417a0d0f8169818efc0041 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Tue, 29 Jul 2008 18:34:53 +0200 Subject: [PATCH] Remove wrong reference The reference is wrong since Debian Policy doesn't have a section 13. Extensions aren't mentioned at all in the "Manual pages" section (12.1); the only reference to extensions appears in the Man-Page-HOWTO, which is linked in the first footnote. --- checks/manpages.desc | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/checks/manpages.desc b/checks/manpages.desc index 57bd2ac..b804af4 100644 --- a/checks/manpages.desc +++ b/checks/manpages.desc @@ -66,7 +66,6 @@ Tag: manpage-has-wrong-extension Type: error Info: The manual page has an extension other than `<i>section</i>[<i>program</i>].gz'. -Ref: policy 13.1 Tag: manpage-not-compressed Type: error -- 1.5.6.3
>From 6aa8810a59aa35192e3fce74dd16c975138f21c5 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Wed, 30 Jul 2008 12:27:24 +0200 Subject: [PATCH] Add new reference to devref changelog-should-mention-nmu is explained in Developer's Reference 5.11.3 (Source NMUs must have a new changelog entry). --- checks/nmu.desc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/checks/nmu.desc b/checks/nmu.desc index d5a4cc7..e7e758f 100644 --- a/checks/nmu.desc +++ b/checks/nmu.desc @@ -49,6 +49,7 @@ Info: When you NMU a package, that fact should be mentioned on the first line Maybe you didn't intend this upload to be a NMU, in that case, please doublecheck that the most recent entry in the changelog is byte-for-byte identical to the maintainer or one of the uploaders. +Ref: devref 5.11.3 Tag: changelog-should-not-mention-nmu Type: warning -- 1.5.6.3
>From 50912993e6a975ea3e790b1d3bbfaa14d38f5919 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Wed, 30 Jul 2008 15:44:59 +0200 Subject: [PATCH] Use Ref: instead of (broken) link --- checks/huge-usr-share.desc | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/checks/huge-usr-share.desc b/checks/huge-usr-share.desc index 9674ade..bb0c3a4 100644 --- a/checks/huge-usr-share.desc +++ b/checks/huge-usr-share.desc @@ -15,7 +15,4 @@ Info: The package has a significant amount of architecture-independent data in . If the data in /usr/share is not architecture-independent, it is a policy violation, and in this case, you should move that data elsewhere. - . - See also: http://www.debian.org/doc/developers-reference/ch-best-pkging-practices#s-bpp-archindepdata - - +Ref: devref 6.7.5 -- 1.5.6.3
>From 85525614a2dec69c59a0a0679dd138f930b1d48b Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Jord=C3=A0=20Polo?= <[EMAIL PROTECTED]> Date: Wed, 30 Jul 2008 17:39:25 +0200 Subject: [PATCH] Add new reference to policy --- checks/lintian.desc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/checks/lintian.desc b/checks/lintian.desc index 3038f03..fd1b170 100644 --- a/checks/lintian.desc +++ b/checks/lintian.desc @@ -57,6 +57,7 @@ Type: error Info: The sections <tt>non-free</tt> and <tt>contrib</tt> are no longer valid. Please use section <tt>non-free/xxx</tt> or <tt>contrib/xxx</tt> instead. +Ref: policy 2.4 Tag: unused-override Type: info -- 1.5.6.3
diff --git a/checks/files.desc b/checks/files.desc index f33fdbc..519b0ed 100644 --- a/checks/files.desc +++ b/checks/files.desc @@ -19,7 +19,7 @@ Type: error Info: The app-defaults files have moved to /etc/X11/app-defaults/. Files in the old directory, /usr/X11R6/lib/X11/app-defaults/, will no longer be used by X. The old directory should not exist in packages at all; - this prevents X from replacing it with a compatability symlink. + this prevents X from replacing it with a compatibility symlink. Ref: policy 11.8.6 Tag: package-installs-font-to-usr-x11r6 @@ -205,6 +205,7 @@ Info: The file is owned by the games group but is not mode 2755. If a game does not have to be setgid games, it should be owned by the root group like any other executable. This executable is either owned by the wrong group or is not setgid when it should be. +Ref: policy 11.11 Tag: non-standard-setuid-executable-perm Type: warning @@ -253,6 +254,7 @@ Type: error Info: The package installs some files into the old <tt>/usr/doc/examples</tt> directory. The new location for examples is <tt>/usr/share/doc/<i>pkg</i>/examples</tt>. +Ref: policy 12.6 Tag: compressed-symlink-with-wrong-ext Type: error diff --git a/checks/huge-usr-share.desc b/checks/huge-usr-share.desc index 9674ade..bb0c3a4 100644 --- a/checks/huge-usr-share.desc +++ b/checks/huge-usr-share.desc @@ -15,7 +15,4 @@ Info: The package has a significant amount of architecture-independent data in . If the data in /usr/share is not architecture-independent, it is a policy violation, and in this case, you should move that data elsewhere. - . - See also: http://www.debian.org/doc/developers-reference/ch-best-pkging-practices#s-bpp-archindepdata - - +Ref: devref 6.7.5 diff --git a/checks/infofiles.desc b/checks/infofiles.desc index 07f16c1..f67fc79 100644 --- a/checks/infofiles.desc +++ b/checks/infofiles.desc @@ -60,7 +60,7 @@ Info: The preinst script calls the <tt>install-info</tt> command. Usually, Tag: install-info-not-called-with-quiet-option Type: warning -Ref: policy 3.10 +Ref: policy 3.9 Info: The package installation scripts should avoid producing output which it is unnecessary for the user to see. Policy specifically mentions install-info output as unnecessary. diff --git a/checks/init.d.desc b/checks/init.d.desc index a9400ab..efbbae7 100644 --- a/checks/init.d.desc +++ b/checks/init.d.desc @@ -59,6 +59,7 @@ Info: <tt>/etc/init.d</tt> scripts should be marked as conffiles. Tag: init.d-script-does-not-implement-required-option Type: error +Ref: policy 9.3.2 Info: The <tt>/etc/init.d</tt> scripts have to support the following command line arguments: start, stop, restart, force-reload. diff --git a/checks/lintian.desc b/checks/lintian.desc index 3038f03..fd1b170 100644 --- a/checks/lintian.desc +++ b/checks/lintian.desc @@ -57,6 +57,7 @@ Type: error Info: The sections <tt>non-free</tt> and <tt>contrib</tt> are no longer valid. Please use section <tt>non-free/xxx</tt> or <tt>contrib/xxx</tt> instead. +Ref: policy 2.4 Tag: unused-override Type: info diff --git a/checks/manpages.desc b/checks/manpages.desc index 57bd2ac..b804af4 100644 --- a/checks/manpages.desc +++ b/checks/manpages.desc @@ -66,7 +66,6 @@ Tag: manpage-has-wrong-extension Type: error Info: The manual page has an extension other than `<i>section</i>[<i>program</i>].gz'. -Ref: policy 13.1 Tag: manpage-not-compressed Type: error diff --git a/checks/menus.desc b/checks/menus.desc index c030fe2..6aff4f2 100644 --- a/checks/menus.desc +++ b/checks/menus.desc @@ -253,7 +253,7 @@ Tag: doc-base-abstract-might-contain-extra-leading-whitespaces Type: warning Info: Continuation lines of the Abstract field of doc-base control file should start with only one space unless they are meant to be displayed - verbatim by fontends. + verbatim by frontends. Ref: Debian doc-base Manual section 2.3.2 Tag: doc-base-abstract-field-separator-extra-whitespaces diff --git a/checks/nmu.desc b/checks/nmu.desc index d5a4cc7..e7e758f 100644 --- a/checks/nmu.desc +++ b/checks/nmu.desc @@ -49,6 +49,7 @@ Info: When you NMU a package, that fact should be mentioned on the first line Maybe you didn't intend this upload to be a NMU, in that case, please doublecheck that the most recent entry in the changelog is byte-for-byte identical to the maintainer or one of the uploaders. +Ref: devref 5.11.3 Tag: changelog-should-not-mention-nmu Type: warning diff --git a/checks/scripts.desc b/checks/scripts.desc index b071a9f..1fffe90 100644 --- a/checks/scripts.desc +++ b/checks/scripts.desc @@ -371,14 +371,14 @@ Info: The maintainer script modifies at least one of the files <tt>/etc/services</tt>, <tt>/etc/protocols</tt>, and <tt>/etc/rpc</tt>, which are managed by the netbase package. Instead of doing this, please file a wishlist bug against netbase to have an appropriate entry added. -Ref: policy 10.7.4 +Ref: policy 11.2 Tag: maintainer-script-modifies-inetd-conf Type: error Info: The maintainer script modifies <tt>/etc/inetd.conf</tt> directly. This file must not be modified directly; instead, use the <tt>update-inetd</tt> script or the <tt>DebianNet.pm</tt> Perl module. -Ref: policy 10.7.4 +Ref: policy 11.2 Tag: install-sgmlcatalog-deprecated Type: error
