On Wed, 2008-07-30 at 22:03 +0200, Jordà Polo wrote: > This is the second (and hopefully last) batch of patches to fix > references and typos in checks/*.desc files.
Thanks (again) for your work on this. I've applied your patch with one exception - rather than removing the Policy reference for manpage-has-wrong-extension, I've updated it to refer to section 12.1 in line with the other tags. > Additionally, there is a reference I'm not sure about. From > checks/shared-libs.desc: > > Tag: shlib-with-executable-bit > Info: Shared libraries should be mode 0644. > Ref: policy 8.1 > > Tag: shlib-with-bad-permissions > Info: Shared libraries should be mode 0644. > Ref: policy 8.1 > > Policy 8.1 states that "Shared libraries should not be installed > executable...", but it doesn't say anything about 0644. So, the first > Ref is probably OK, but I'm not sure about the second one. Should it > point to 10.9 instead, or there is no need to be so strict? The first reference is fine, imo. Although the description mentions 0644, what's actually tested is whether the file is executable, as per the tag name. The second is more debatable. As you mentioned, 10.9 defines what "non-executable" means in terms of file modes and the test here does check for a mode exactly matching 0644. I'm not sure it's sufficiently debatable to change, however. Adam -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
