Russ Allbery wrote:
> Raphael Geissert writes:
>
>> --- a/lib/Lintian/Command.pm
>> +++ b/lib/Lintian/Command.pm
>> @@ -303,7 +303,7 @@ all the executions of kill_kill.
>> =cut
>>
>> sub kill {
>> - my $status;
>> + my $status = 0;
>> while (my $opts = shift @_) {
>> $status |= kill_kill($opts->{'harness'}, grace => 2);
>> }
>
> Also, ||= is more correct, although if the return value of kill_kill is
> always either 1 or 0, it won't matter in this case. (But |= is almost
> always wrong in Perl unless you're actually manipulating bitmasks.)
>
I don't know why I had the idea that it returned the return code of the
process. But taking a look at it again, I think we want && here, so that 1
is returned only if none of the processes had to be SIGKILLed.
Cheers,
--
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
