This is an automated email from the git hooks/post-receive script. broucaries-guest pushed a commit to branch master in repository lintian.
commit 446bc24d82cac311cdd392b54d5517fefbb15f5e Author: Bastien ROUCARIÈS <[email protected]> Date: Sat Dec 14 13:01:57 2013 +0100 Rename adduser-system-without-home to maintainer-script-should-not-use-adduser-system-without-home Signed-off-by: <[email protected]> --- checks/scripts.desc | 2 +- data/scripts/maintainer-script-bad-command | 34 +++++++++++++++--------------- t/tests/scripts-maintainer-general/desc | 2 +- t/tests/scripts-maintainer-general/tags | 4 ++-- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git a/checks/scripts.desc b/checks/scripts.desc index fb8ac4f..c146104 100644 --- a/checks/scripts.desc +++ b/checks/scripts.desc @@ -595,7 +595,7 @@ Info: The maintainer script apparently runs install-sgmlcatalog. Given how long ago this transition was, consider removing it entirely. -Tag: adduser-system-without-home +Tag: maintainer-script-should-not-use-adduser-system-without-home Severity: serious Certainty: certain Info: The maintainer script apparently runs adduser --system diff --git a/data/scripts/maintainer-script-bad-command b/data/scripts/maintainer-script-bad-command index b1013db..e251a69 100644 --- a/data/scripts/maintainer-script-bad-command +++ b/data/scripts/maintainer-script-bad-command @@ -19,22 +19,22 @@ # # Please alpha sort by tag # -adduser-system-without-home ~~ 1 ~~ ~~ ~~adduser\s+--system(?=\s)(?!.*\s--home\s+/(?!home/)) -ancient-dpkg-epoch-check ~~ 0 ~~ ~~ ~~${LEADIN}dpkg\s+--assert-working-epoch\b -ancient-dpkg-multi-conrep-check ~~ 0 ~~ ~~ ~~${LEADIN}dpkg\s+--assert-multi-conrep\b -deprecated-chown-usage ~~ 0 ~~ ~~ ~~(chown(?:\s+--?[A-Za-z-]+)*\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+ -install-info-used-in-maintainer-script ~~ 1 ~~ ~~ ~~\binstall-info\b -install-sgmlcatalog-deprecated ~~ 1 ~~ ~~ ~~\binstall-sgmlcatalog\b -maintainer-script-hides-init-failure ~~ 0 ~~ ~~ ~~invoke-rc.d.*\|\| \s+ exit \s+ 0 -maintainer-script-modifies-ld-so-conf ~~ 0 ~~^libc ~~ ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)/etc/ld\.so\.conf\s*(?:\s|\Z) -maintainer-script-modifies-netbase-managed-file ~~ 0 ~~ ~~ ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)(/etc/(?:services|protocols|rpc))\s*(?:\s|\Z) -maintainer-script-removes-device-files ~~ 0 ~~ ~~ ~~^\s*rm\s+(?:[^>]*\s)?(/dev/(?!(?:shm/|\.[^.]+))[^/ ]+) -maintainer-script-uses-dpkg-status-directly ~~ 1 ~~^(base-files|dpkg)$ ~~ ~~/var/lib/dpkg/status\b -maintainer-script-should-not-use-fc-cache ~~ 0 ~~^(fontconfig)$ ~~ ~~${LEADIN}(?:/usr/bin/)?fc-cache(?:\s|\Z) -maintainer-script-should-not-use-gconftool ~~ 1 ~~^(gconf\d)$ ~~ ~~(?:/usr/bin/)?gconftool(?:-\d)?(?:\s|\Z) -update-alternatives-remove-called-in-postrm ~~ 1 ~~ ~~^postrm$ ~~\b update\-alternatives\s+\-\-remove\b -update-alternatives-set-called-in-maintainer-script ~~ 1 ~~ ~~ ~~\b update\-alternatives\s+\-\-(?:set|set\-selections|config)\b -start-stop-daemon-in-maintainer-script ~~ 0 ~~ ~~ ~~\s*start-stop-daemon(?=\s)(?!.*\s--stop\b) -suidregister-used-in-maintainer-script ~~ 1 ~~ ~~ ~~\bsuidregister\b +ancient-dpkg-epoch-check ~~ 0 ~~ ~~ ~~${LEADIN}dpkg\s+--assert-working-epoch\b +ancient-dpkg-multi-conrep-check ~~ 0 ~~ ~~ ~~${LEADIN}dpkg\s+--assert-multi-conrep\b +deprecated-chown-usage ~~ 0 ~~ ~~ ~~(chown(?:\s+--?[A-Za-z-]+)*\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+ +install-info-used-in-maintainer-script ~~ 1 ~~ ~~ ~~\binstall-info\b +install-sgmlcatalog-deprecated ~~ 1 ~~ ~~ ~~\binstall-sgmlcatalog\b +maintainer-script-hides-init-failure ~~ 0 ~~ ~~ ~~invoke-rc.d.*\|\| \s+ exit \s+ 0 +maintainer-script-modifies-ld-so-conf ~~ 0 ~~^libc ~~ ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)/etc/ld\.so\.conf\s*(?:\s|\Z) +maintainer-script-modifies-netbase-managed-file ~~ 0 ~~ ~~ ~~(?:\A\s*(?:cp|mv)\s+.*\s+|>\s*)(/etc/(?:services|protocols|rpc))\s*(?:\s|\Z) +maintainer-script-removes-device-files ~~ 0 ~~ ~~ ~~^\s*rm\s+(?:[^>]*\s)?(/dev/(?!(?:shm/|\.[^.]+))[^/ ]+) +maintainer-script-uses-dpkg-status-directly ~~ 1 ~~^(base-files|dpkg)$ ~~ ~~/var/lib/dpkg/status\b +maintainer-script-should-not-use-adduser-system-without-home ~~ 1 ~~ ~~ ~~adduser\s+--system(?=\s)(?!.*\s--home\s+/(?!home/)) +maintainer-script-should-not-use-fc-cache ~~ 0 ~~^(fontconfig)$ ~~ ~~${LEADIN}(?:/usr/bin/)?fc-cache(?:\s|\Z) +maintainer-script-should-not-use-gconftool ~~ 1 ~~^(gconf\d)$ ~~ ~~(?:/usr/bin/)?gconftool(?:-\d)?(?:\s|\Z) +update-alternatives-remove-called-in-postrm ~~ 1 ~~ ~~^postrm$ ~~\b update\-alternatives\s+\-\-remove\b +update-alternatives-set-called-in-maintainer-script ~~ 1 ~~ ~~ ~~\b update\-alternatives\s+\-\-(?:set|set\-selections|config)\b +start-stop-daemon-in-maintainer-script ~~ 0 ~~ ~~ ~~\s*start-stop-daemon(?=\s)(?!.*\s--stop\b) +suidregister-used-in-maintainer-script ~~ 1 ~~ ~~ ~~\bsuidregister\b diff --git a/t/tests/scripts-maintainer-general/desc b/t/tests/scripts-maintainer-general/desc index 34d99e3..9286860 100644 --- a/t/tests/scripts-maintainer-general/desc +++ b/t/tests/scripts-maintainer-general/desc @@ -6,7 +6,6 @@ Profile: ubuntu/main Distribution: precise Description: Check general problems in maintainer scripts Test-For: - adduser-system-without-home command-with-path-in-maintainer-script deprecated-chown-usage install-info-used-in-maintainer-script @@ -24,6 +23,7 @@ Test-For: maintainer-script-removes-device-files maintainer-script-uses-dpkg-status-directly maintainer-shell-script-fails-syntax-check + maintainer-script-should-not-use-adduser-system-without-home maintainer-script-should-not-use-fc-cache maintainer-script-should-not-use-gconftool mknod-in-maintainer-script diff --git a/t/tests/scripts-maintainer-general/tags b/t/tests/scripts-maintainer-general/tags index 9f5affa..7f36258 100644 --- a/t/tests/scripts-maintainer-general/tags +++ b/t/tests/scripts-maintainer-general/tags @@ -1,5 +1,3 @@ -E: scripts-maintainer-general: adduser-system-without-home postinst:148 -E: scripts-maintainer-general: adduser-system-without-home postinst:149 E: scripts-maintainer-general: install-sgmlcatalog-deprecated postinst:74 E: scripts-maintainer-general: install-sgmlcatalog-deprecated postinst:75 E: scripts-maintainer-general: maintainer-script-modifies-inetd-conf postinst:67 @@ -12,6 +10,8 @@ E: scripts-maintainer-general: maintainer-script-modifies-netbase-managed-file p E: scripts-maintainer-general: maintainer-script-removes-device-files postinst:141 '/dev/null' E: scripts-maintainer-general: maintainer-script-uses-dpkg-status-directly postinst:56 E: scripts-maintainer-general: maintainer-shell-script-fails-syntax-check prerm +E: scripts-maintainer-general: maintainer-script-should-not-use-adduser-system-without-home postinst:148 +E: scripts-maintainer-general: maintainer-script-should-not-use-adduser-system-without-home postinst:149 E: scripts-maintainer-general: mknod-in-maintainer-script postinst:125 E: scripts-maintainer-general: read-in-maintainer-script postinst:10 E: scripts-maintainer-general: suidregister-used-in-maintainer-script postinst:101 -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
