This is an automated email from the git hooks/post-receive script. broucaries-guest pushed a commit to branch master in repository lintian.
commit 4ef84eba3fdbb6b43f8f9112ddd98e8c5445d050 Author: Bastien ROUCARIÈS <[email protected]> Date: Sat Dec 14 15:19:41 2013 +0100 Rename maintainer-script-uses-dpkg-status-directly to maintainer-script-should-not-use-dpkg-status-directly --- checks/scripts.desc | 2 +- data/scripts/maintainer-script-bad-command | 5 ++++- debian/changelog | 6 ++++-- t/tests/scripts-maintainer-general/desc | 2 +- t/tests/scripts-maintainer-general/tags | 2 +- 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/checks/scripts.desc b/checks/scripts.desc index 6f48502..6c62336 100644 --- a/checks/scripts.desc +++ b/checks/scripts.desc @@ -536,7 +536,7 @@ Info: This script apparently runs <tt>install-info</tt>. Updating the If debhelper generated the maintainer script fragment, rebuilding the package with debhelper 7.2.17 or later will fix this problem. -Tag: maintainer-script-uses-dpkg-status-directly +Tag: maintainer-script-should-not-use-dpkg-status-directly Severity: important Certainty: certain Info: The file /var/lib/dpkg/status is internal to dpkg, may disappear or diff --git a/data/scripts/maintainer-script-bad-command b/data/scripts/maintainer-script-bad-command index c723c28..1ecf44b 100644 --- a/data/scripts/maintainer-script-bad-command +++ b/data/scripts/maintainer-script-bad-command @@ -19,15 +19,18 @@ # # Please alpha sort by tag # + # ftpmaster auto reject so do not rename install-info-used-in-maintainer-script ~~ 1 ~~ ~~ ~~\binstall-info\b +# ftpmaster auto reject so do not rename maintainer-script-removes-device-files ~~ 0 ~~ ~~ ~~^\s*rm\s+(?:[^>]*\s)?(/dev/(?!(?:shm/|\.[^.]+))[^/ ]+) -maintainer-script-uses-dpkg-status-directly ~~ 1 ~~^(base-files|dpkg)$ ~~ ~~/var/lib/dpkg/status\b + maintainer-script-should-not-hide-init-failure ~~ 0 ~~ ~~ ~~invoke-rc.d.*\|\| \s+ exit \s+ 0 maintainer-script-should-not-use-adduser-system-without-home ~~ 1 ~~ ~~ ~~adduser\s+--system(?=\s)(?!.*\s--home\s+/(?!home/)) maintainer-script-should-not-use-ancient-dpkg-epoch-check ~~ 0 ~~ ~~ ~~${LEADIN}dpkg\s+--assert-working-epoch\b maintainer-script-should-not-use-ancient-dpkg-multi-conrep-check~~ 0 ~~ ~~ ~~${LEADIN}dpkg\s+--assert-multi-conrep\b maintainer-script-should-not-use-deprecated-chown-usage ~~ 0 ~~ ~~ ~~(chown(?:\s+--?[A-Za-z-]+)*\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+ +maintainer-script-should-not-use-dpkg-status-directly ~~ 1 ~~^(base-files|dpkg)$ ~~ ~~/var/lib/dpkg/status\b maintainer-script-should-not-use-fc-cache ~~ 0 ~~^(fontconfig)$ ~~ ~~${LEADIN}(?:/usr/bin/)?fc-cache(?:\s|\Z) maintainer-script-should-not-use-gconftool ~~ 1 ~~^(gconf\d)$ ~~ ~~(?:/usr/bin/)?gconftool(?:-\d)?(?:\s|\Z) maintainer-script-should-not-use-install-sgmlcatalog ~~ 1 ~~ ~~ ~~\binstall-sgmlcatalog\b diff --git a/debian/changelog b/debian/changelog index a5c5311..1ad2841 100644 --- a/debian/changelog +++ b/debian/changelog @@ -51,9 +51,11 @@ lintian (2.5.20) UNRELEASED; urgency=low + [BR] Rename maintainer-script-hides-init-failure to maintainer-script-should-not-hide-init-failure. + [BR] Rename maintainer-script-modifies-ld-so-conf to - maintainer-script-should-not-modify-ld-so-conf + maintainer-script-should-not-modify-ld-so-conf. + [BR] Rename maintainer-script-modifies-netbase-managed-file to - maintainer-script-should-not-modify-netbase-managed-file + maintainer-script-should-not-modify-netbase-managed-file. + + [BR] Rename maintainer-script-uses-dpkg-status-directly to + maintainer-script-should-not-use-dpkg-status-directly. * checks/standards-version: + [BR] Use Lintian::Data for ancient date check. * checks/watch.{desc,pm}: diff --git a/t/tests/scripts-maintainer-general/desc b/t/tests/scripts-maintainer-general/desc index a355399..f595abb 100644 --- a/t/tests/scripts-maintainer-general/desc +++ b/t/tests/scripts-maintainer-general/desc @@ -16,11 +16,11 @@ Test-For: maintainer-script-needs-depends-on-ucf maintainer-script-needs-depends-on-xml-core maintainer-script-removes-device-files - maintainer-script-uses-dpkg-status-directly maintainer-shell-script-fails-syntax-check maintainer-script-should-not-hide-init-failure maintainer-script-should-not-use-adduser-system-without-home maintainer-script-should-not-use-deprecated-chown-usage + maintainer-script-should-not-use-dpkg-status-directly maintainer-script-should-not-use-fc-cache maintainer-script-should-not-use-gconftool maintainer-script-should-not-use-install-sgmlcatalog diff --git a/t/tests/scripts-maintainer-general/tags b/t/tests/scripts-maintainer-general/tags index f446057..ac0f503 100644 --- a/t/tests/scripts-maintainer-general/tags +++ b/t/tests/scripts-maintainer-general/tags @@ -8,9 +8,9 @@ E: scripts-maintainer-general: maintainer-script-should-not-modify-netbase-manag E: scripts-maintainer-general: maintainer-script-should-not-modify-netbase-managed-file postinst:61 '/etc/rpc' E: scripts-maintainer-general: maintainer-script-should-not-use-adduser-system-without-home postinst:148 E: scripts-maintainer-general: maintainer-script-should-not-use-adduser-system-without-home postinst:149 +E: scripts-maintainer-general: maintainer-script-should-not-use-dpkg-status-directly postinst:56 E: scripts-maintainer-general: maintainer-script-should-not-use-install-sgmlcatalog postinst:74 E: scripts-maintainer-general: maintainer-script-should-not-use-install-sgmlcatalog postinst:75 -E: scripts-maintainer-general: maintainer-script-uses-dpkg-status-directly postinst:56 E: scripts-maintainer-general: maintainer-shell-script-fails-syntax-check prerm E: scripts-maintainer-general: mknod-in-maintainer-script postinst:125 E: scripts-maintainer-general: read-in-maintainer-script postinst:10 -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
