Hi Mathieu and Roberto Mathieu, do you mean that they patches should apply cleanly and if they do not, then we have missed some other important patch, or do you just mean that they should generally apply cleanly?
I'm asking as it is rather expected that patches do not apply cleanly when we are dealing with these old versions in wheezy. I do not want to give a precise estimate but something between 20 and 60% of the patches that I have applied to the packages I have done updates to in wheezy have not applied cleanly. Usually it is just minor things, but in some cases quite a lot of work have to be put in understanding the problem and finding out a new fix. We should not be afraid to do that kind of work. We do have the possibility to update to the latest software also in wheezy but that should really be done as a last resort, or only for packages that have a very good reputation on backwards compatibility. At least that is how I have understood the current practices. I mean we do not want to introduce unnecessary regressions. Best regards // Ola On 28 March 2017 at 12:55, Roberto C. Sánchez <robe...@connexer.com> wrote: > On Tue, Mar 28, 2017 at 11:34:44AM +0200, Mathieu Parent wrote: > > Hi, > > > > 2017-03-26 14:39 GMT+02:00 Roberto C. Sánchez <robe...@connexer.com>: > > > On Thu, Mar 23, 2017 at 11:30:09AM +0100, Mathieu Parent wrote: > > >> > > >> See attached the backported patches for 3.6 (those are from the samba > > >> bugzilla which is still embargoed). > > >> > > >> Please take care of it. > > >> > > > > > > Hi Mathieu, > > > > > > I wanted to let you know that I had to make a minor tweak to patch > 08/15 > > > in order to get the build to succeed on wheezy. I wanted let everyone > > > know in the event that I have missed something important and for > general > > > awareness. > > > > Again, don't upload yet. We have 2 regressions (maybe 3) in jessie. > > > Yes, of course. I am still waiting for the resolution of at least > #858564 and #858590. > > > > I had to change this hunk: > > [...] > > > > Me too, I'm not a samba developer. If a patch doesn't apply, it's > > because of one in debian/patches, or > > maybe a requirement from 3.6. > > > > debian wheezy is based on 3.6.6, while latest 3.6 is 3.6.25. Maybe the > > first thing to do is to update to 3.6.25. > > > OK. I did wonder at first why jessie was updated to the latest 4.2 but > wheezy was not updated to the latest 3.6. > > > > > > > The resolution for this one is not obvious to me. I intend to dig into > > > it, but if anyone has a suggestion, I welcome it. > > > > Don't change the patches. They should apply cleanly. > > > OK. That is good to know. > > > Hope this helps. > > > It does help. I certainly don't want to cause a problem with a package > so widely used as Samba. > > Regards, > > -Roberto > > -- > Roberto C. Sánchez > http://people.connexer.com/~roberto > http://www.connexer.com > > -- --- Inguza Technology AB --- MSc in Information Technology ---- / o...@inguza.com Folkebogatan 26 \ | o...@debian.org 654 68 KARLSTAD | | http://inguza.com/ Mobile: +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / ---------------------------------------------------------------