Hi Amul,

On Fri, Sep 26, 2014 at 11:50:28PM -0400, Amul Shah wrote:
> > >
> > > [amul:1] I didn't see this lintian message. That said, cleaning
> > > things up in the upstream is preferable. The fewer exceptions the
> > > better.
> > 
> > You need to call
> > 
> >    lintian -I
> > 
> > to get these.

BTW, you can also set this:

$ grep display-info ~/.lintianrc 
display-info=yes

> [amul:3] These warnings made me chuckle a bit. I didn't realize that we had 
> typos in our messaging from C sources. The flagging of M sources below 
> occurred because of the technique we adopted to handle the DESTDIR problem.
> 
> instance1:~> lintian --display-info fis-gtm-6.2-000_6.2-000-1_amd64.deb 
> I: fis-gtm-6.2-000: spelling-error-in-binary 
> usr/lib/x86_64-linux-gnu/fis-gtm/V6.2-000_x86_64/dse accomodate accommodate
> I: fis-gtm-6.2-000: spelling-error-in-binary 
> usr/lib/x86_64-linux-gnu/fis-gtm/V6.2-000_x86_64/libgtmutil.so begining 
> beginning
> I: fis-gtm-6.2-000: spelling-error-in-binary 
> usr/lib/x86_64-linux-gnu/fis-gtm/V6.2-000_x86_64/utf8/libgtmutil.so begining 
> beginning

I wonder whether you'd call this relevant for an upload or not (for me
it would be not if next upstream version would be fixed.)

> I: fis-gtm-6.2-000: unused-override shared-lib-without-dependency-information 
> usr/lib/*/fis-gtm/*/utf8/libgtmutil.so
> N: 12 tags overridden (12 warnings)
> 
> [amul:3] The above warnings require changes to the following lines. I will 
> fix these in the upstream.
> sr_port/dse_shift.c:131:                      util_out_print("Error:  block 
> not large enough to accomodate shift.", TRUE);
> sr_port/rsel.mpt:124:        e  s strt=$$mask(beg),stop=$$mask(end) i 
> $l($p(stop,"$")) q:stop']strt              ; if end before begining, done
> sr_port/rsel.mpt:128: f  s r=$$search(pct) q:r]stop!'$l(r)  d save            
>                             ; do begining
> sr_port/xcmd.mpt:17:  ; Protect %XCMD's error handler by NEWing and SETing 
> $ETRAP at the begining of the XECUTEd comma

Good.

There is also a

I: fis-gtm source: quilt-patch-missing-description 
upstream_build_all_encryption_libs

left which would be helpful to be fixed.
 
> [amul:3] Note that there is an unused override. I will remove it later. 

OK.

> > [amul:2] I have the patch to build all three encryption plugins and the 
> > default symlink. I will push this set of changes soon. Please take a look. 
> > If you are fine with the changes, V6.2-000 is ready for upload. :)
> 
> [amul:3] I think we hit a major milestone in the packaging of GT.M. Two 
> packages released back to back! With one delayed by a tinsy six months. ;)

Yes.  Good job!  We would not be able to do this without your insight to
upstream code.

Thanks for your work on this

     Andreas.
 

-- 
http://fam-tille.de


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: https://lists.debian.org/[email protected]

Reply via email to