Hi Tanya, On Wed, Jun 29, 2016 at 01:35:38PM +0300, merlettaia wrote: > > 2016-06-22 11:39 GMT+03:00 Andreas Tille <[email protected]>: > > > > Conservation-code, > > > > I realised that there is no such matrix blosum63.bla even in the source > > package (only 62). Similarliy with swissprot1.distribution - we just > > have swissprot.distribution (without "1"). Do you have any explanation > > for this? > > I removed this from test and added some description (describing this > behavior) to README.test instead.
Good. Package is uploaded now. > > > * pdb2pqr - added 3 tests, fixed lintian warnings. > > > > At first I need to say that I'm very happy about your engaged work on > > the packages your are touching. It is a proof of deeper understanding > > of Debian packaging. Your changelog regarding non-test issues is > > impressing and very appreciated. I wonder whether you are interested in > > staying in the Debian Med team even after this outreachy project and to > > apply as Debian Maintained. I would definitely support this intention. > > Yes, I'm interested :) Very good. Feel free to decide yourself if you apply right now and may be do the first upload your own at the end of the outreachy program or wait a bit and apply afterwards. Its your decision how you are feeling about it. > > I consider it a sensible strategy to provide other tests than those that > > are done at build time if it turns out as to complex for the moment. > > Your tests are looking sensible and we can keep on working on even more > > fine grained tests later if necessary. > > > > $ sh pdb2pka-test > > Run pdb2pqr... > > ... > > This smells like a missing Dependency. Could you please investigate > > which package might provide this? > > > > Pdb2pqr uses SWIG (http://www.swig.org/), so this error is SWIG-specific. > For me this error appeared when one of interface files, which should be > regenerated, was replaced by backup file (and it simply dissapeared when it > was regenerated). I'll check this package again now and describe in next > letter how to avoid this. OK. Thanks for your work on this Andreas. -- http://fam-tille.de
