On Sun, Aug 20, 2017 at 06:19:02AM +0000, Cédric Lood wrote:
>
> > Fine.
>
> Alright, the package builds. There are minor problems that I have mentioned
> to the upstream author but that can easily be corrected. The first one is the
> omission of a necessary qt library atop of the qtbase5-dev [0] (for this I
> have sent him a pull request). And the second one is a problem with the file
> used by qmake to generate a makefile. The file, called "Bandage.pro", has a
> set of INCLUDE variables that result in a build failure when using the
> generated makefile. I noticed the upstream author has fixed that in the dev
> branch, so I just mentioned it to him via an existing request for a new
> release [1].
>
> I think the first problem can be easily fixed on our side by including the
> proper library in the debian/control - Build-Depends field. For the second
> problem, I guess a patch is in order?
Yes, there are missing Build-Depends, which need to be fixed (as I
tried to point out in my answer to your other mail). And, yes, patches
are for sure in order. Please use quilt for this.
Kind regards
Andreas.
> [0] https://github.com/rrwick/Bandage/blob/master/README.md#-ubuntu
> [1] https://github.com/rrwick/Bandage/issues/44
>
--
http://fam-tille.de
