Control: tags -1 moreinfo On Sun, Mar 11, 2018 at 06:48:10PM +0100, Gard Spreemann wrote: > On Sunday 11 March 2018 00:18:32 CET Gard Spreemann wrote: > > On Wednesday 7 March 2018 19:32:48 CET Tobias Frost wrote: > > > Please review d/copyright. I found at least one undocumented file which > > > is licensed Apache 2.0 and another one under LGPL3+. Neither are in > > > d/copyright. > > > > I'm looking into this, and will get back to you. > > > > I've updated the copyright information for the Apache 2.0-licensed > file, as well as another MIT-licensed file with missing coverage.
Thanks!. Note that some files are claimed copyright just by "20xx INRIA" and "20xx INRIA (France)" As copyright must be verbatim, you need to addtionalyl write this in d/copyright. Not sure about all those other variants of INRIA: Are they different organisattions (like a subsidiary) of just different writing of the same one? In the first case, you need to have one stanca for every different organisations, (hint: license-reconcile might help here) > It turns out that the swaths of LGPL3+-licensed files were CGAL > patches carried by upstream to support CGAL << 4.11. Since CGAL 4.11.1 > is in buster, and there's already a lot of DFSG modifications to the > upstream source in my package, I simply added deletion of these > patches in the DFSG modifications and bumped the CGAL version > requirements accordingly. I verified that the patches are only used > when CGAL << 4.11 is detected. Is this satisfactory? Yes, this will work. Speaking about external sources... I see that there is also cpython in the source. As cpython is packaged, can it be also removed via Files-Exluded (as you said, you're repacking already, so we can reduce the size of the source package even more) > A new version has been uploaded to mentors: > > https://mentors.debian.net/debian/pool/main/g/gudhi/gudhi_2.1.0+dfsg-1.dsc Older stuff already mentioned, but still not fixed: - many versioned build dependencies are already satisfied since oldstable. As thus those old version constraint can be removed, especially as this is a new package. Many thanks for putting doxygen generation into build-indep! > > Thanks again! > > -- Gard Ok, otherwise package is ready... So please fix the last bits, especially the copyright remarks, and then it will be ready. -- tobi