On Sat, Apr 06, 2019 at 07:13:56PM +0000, Dmitry Bogatov wrote: > > [2019-04-04 13:30] Mathieu Mirmont <m...@parad0x.org> > > > * I know, it is pain, but there should be init.d script. You may want to > > > take a look at bcron=0.11-8. > > > > Sure, no worries. How about systemd service files? It makes little sense > > to run socklog along with systemd I think, but for the principle it may > > be required to profile service files. What do you think? > > Up to you. Presence of systemd unit files is not mandated by Policy, > unlike init.d scripts.
Done, the init scripts call daemon(1) and runsv(1) and they work pretty nicely. > > > I believe there should be separate sysuser for socklog-* services. > > > Ideally, separate sysuser for /every/ from socklog-* service, but I do > > > not know, whehter it is possible. > > > > Yeah good point. I tend to think that a single user for all socklog-* > > services would be enough, but if you prefer I can add one user per > > service. > > Yes, I'd prefer as much separation, as possible. Done, one user per service. > > Thanks for the review! > > My pleasure. By the way, you seems to forgot to add changelog entry > about new maintainer. Something in lines: > > * Set myself as maintainer (Closes: #<orphan-bug-of-socklog>) I had this line but somehow I messed up and accidentally squashed two commits so the line disappeared (I use gbp dch to generate the changelog). I've put it back. There is one more issue that I noticed this weekend: the orig.tar.gz file that is registered in debian archives is not the same as the upstream tarball. It is in fact a tarball of the upstream tarball (!). I don't know why it's done this way, and it pretty much breaks breaks source format 3.0 (quilt) because I can't get dpkg-source to unpack the tarball before applying the patches. Do you know how to deal with that? -- Mathieu Mirmont <m...@parad0x.org>
signature.asc
Description: PGP signature
