Control: tags -1 -moreinfo

Thanks for reviewing!

On Wed, 2026-06-03 at 09:43 +0000, Jeroen Ploemen wrote:
> * copyright: missing info for:
>   gui/gnomint.appdata.xml.in:5:  <metadata_license>CC0-
> 1.0</metadata_license>
>   po/it.po:2:# Copyright (c) 2008 Rosetta Contributors and Canonical
> Ltd 2008
>   po/oc.po:2:# Copyright (c) 2010 Rosetta Contributors and Canonical
> Ltd 2010
>   po/ca.po:2:# Copyright (c) 2009 Rosetta Contributors and Canonical
> Ltd 2009
>   po/sk.po:2:# Copyright (c) 2010 Rosetta Contributors and Canonical
> Ltd 2010
>   po/pt_BR.po:2:# Copyright (c) 2009 Rosetta Contributors and
> Canonical Ltd 2009
>   po/fi.po:2:# Copyright (c) 2009 Rosetta Contributors and Canonical
> Ltd 2009
>   po/de.po:2:# Copyright (c) 2008 Rosetta Contributors and Canonical
> Ltd 2008
>   po/ru.po:2:# Copyright (c) 2009 Rosetta Contributors and Canonical
> Ltd 2009

I added copyright entries of .po files and gui/gnomint.appdata.xml.in
along with the CC0-1.0 license.

> * d/upstream/metadata file is missing, please add. Note that the
>   upstream README file lists the github project for issues and
>   patches (rather than sourceforge).

Added.

> * changelog: still mentions the presence of several patches that
>   meanwhile were forwarded upstream (great!) and merged into the
>   currently packaged release. You probably want to change the
>   relevant changelog entry to indicate that all patches have actually
>   been dropped from the packaging now.

The changelog now explicitly lists all patches as dropped.

> * tests are disabled entirely, but many of the tests/check_cli_*.sh
>   scripts look like they could be put to good use in an autopkgtest
>   context, along the lines of [1]. I don't consider this a blocker
>   for sponsorship though.

d/tests/ has been added. All check_cli_*.sh tests pass.

Changes have been pushed to salsa and a new version of the package has
been uploaded to mentors.debian.net.

Thanks,


-- 
Haolin Xue

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to