Hi Simon,
Thank you for the review and for sponsoring crumb!
I've addressed all your notes in 1.1.0-2:
- Dropped Priority and Rules-Requires-Root.
- Moved to debhelper-compat 14.
- Converted debian/watch to version 5.
- Replaced the superficial smoke test with real autopkgtests: one runs
the upstream test suite against the packaged crates, and one
exercises the installed binary offline (completions, an MCP
handshake and tool call, and the job store). Both pass in a clean
unstable schroot.
1.1.0-2 also fixes what the DFSG review of 1.1.0-1 found in
debian/copyright: the Sigstore test fixtures are Apache-2.0, the
CC-BY-4.0 stanza now covers only the website images, and the Pollinations
logo is credited to pollinations.ai under MIT.
Salsa: https://salsa.debian.org/elixpo/crumb (tag debian/1.1.0-2)
dget -x
https://mentors.debian.net/debian/pool/main/c/crumb/crumb_1.1.0-2.dsc
Would you be willing to upload 1.1.0-2 now, so ftpmasters review the
fixed version, or would you prefer to wait for NEW's decision on 1.1.0-1?
On de-vendoring: crumb doesn't vendor any third-party crates; every
external dependency comes from Debian's librust-*-dev packages. Did you
mean crumb's own workspace crates (crumb-core, crumb-tools and so on)?
They aren't published on crates.io yet, so splitting them into
debcargo-conf would mean publishing them upstream first. I'm happy to work
towards that if it's what you had in mind.
Best regards,
Ayushman Bhattacharya
On Mon, Oct 26, 2026 at 1:55 AM Simon Quigley <[email protected]> wrote:
> Hi Ayushman,
>
> Thanks for your work here, and for pinging on #debian-rust (that's how I
> found this).
>
> I have a few nitpicks that can be addressed on the next upload:
> - You can drop Priority: optional and Rules-Requires-Root: no with
> Standards-Version 4.7.4.
> - Please consider upgrading to debhelper-compat 14.
> - Long-term, please consider de-vendoring the crates and moving them
> under debcargo-conf.
> - Please upgrade the watch file to version 5.
> - Please make the tests real.
>
> Otherwise, uploaded:
>
> $ dput ssh-upload ../crumb_1.1.0-1_amd64.changes
> Uploading crumb using sftp to ssh-upload (host: ssh.upload.debian.org;
> directory: /srv/upload.debian.org/UploadQueue/)
> running allowed-distribution: check whether a local profile permits
> uploads to the target distribution
> running protected-distribution: warn before uploading to distributions
> where a special policy applies
> running checksum: verify checksums before uploading
> running suite-mismatch: check the target distribution for common errors
> running gpg: check GnuPG signatures before the upload
> Logging into host ssh.upload.debian.org as tsimonq2
> Uploading crumb_1.1.0-1.dsc
> Uploading crumb_1.1.0.orig.tar.gz
> Uploading crumb_1.1.0-1.debian.tar.xz
> Uploading crumb-dbgsym_1.1.0-1_amd64.deb
> Uploading crumb_1.1.0-1_amd64.buildinfo
> Uploading crumb_1.1.0-1_amd64.deb
> Uploading crumb_1.1.0-1_amd64.changes
>
> It will now go to the Debian NEW queue, where it will be accepted or
> rejected. If it is rejected, please do CC me on the followup, and if I'm
> available, I can take another look.
>
> Feel free to let me know if you have any questions.
>
> Best regards,
> Simon Quigley
> [email protected]
>
