Dear Daniel, once again, thanks for the review. On Nov 03 2006, Daniel Baumann wrote: > Rogério Brito wrote: > > Thank you very much for the review. It is one of the things that I was > > looking for, since I want to use the best-current practices. > > well, you could do it much better, if you care..
Yes, I do care. Those are the perils of maintaining a package that was long ago forgotten/neglected (if you see the BTS and the page at <http://packages.debian.org/changelogs/pool/main/v/vrms/current/changelog>, you'll will see that the package had a long hiatus of being maintained and I'm just picking it up). Since vrms itself is one package for quality assurance (and this is one of the things I care a lot, so that we can have better a better distribution), it is imperative to have it be well written (and I didn't even get started with the program itself). > * since you don't build anything in build:, you can just write > > ---snipp--- > build: > ---snapp--- (...) Fixed. > ---snipp--- > install: build > ---snapp--- Fixed. > * installing with -o and -g is useless, will be fixed by dh_fixperms > later anyway. I tried to fix this, but I can't find a way to tell dh_fixperms to not make vrms/reasons/vrms executable (yes, experimenting with -X, --exclude and various ways of telling it didn't work on my system). I included a dirty hack there. Any suggestions for improvements here? > * dh_installmenu is useless, you don't have any menu anyway. Fixed. > ....and remove the useless empty line at the end of README.Debian. Fixed. > tell me if you care for these things and want to fix them, or if i > should upload the current one. I think that now the package is more polished. Please let me know if anything else should be improved. Just for redundancy's sake, here is the information about the package (again): * URL: http://www.ime.usp.br/~rbrito/debian/ * dget http://www.ime.usp.br/~rbrito/debian/vrms_1.12.dsc * svn repository: http://svn.debian.org/wsvn/vrms Regards, Rogério Brito. -- Rogério Brito : [EMAIL PROTECTED] : http://www.ime.usp.br/~rbrito Homepage of the algorithms package : http://algorithms.berlios.de Homepage on freshmeat: http://freshmeat.net/projects/algorithms/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
