Hi Arno, Thank you for extensive review and useful advices.
As I just learned, quick maintainer change to QA invalidates NMU version number hence lintian warnings. I fixed that and re-uploaded source package: http://mentors.debian.net/debian/pool/main/d/dvbackup/dvbackup_0.0.4rj1-7.dsc Please find debdiff output attached. Also I updated changelog as you suggested, on order to mention what has been done. I already fixed dozen lintian warnings but of course --pedantic bring more. Strangely enough, for some reason my lintian doesn't give me warnings about documentation. I don't know how to regenerate man pages. For a moment I'm going to leave it as is. I have no intention to make it perfect, just a little bit better. I'm not sure it worth too much effort because, as you might know, upstream is not active for years, so package likely won't have a bright future. Regards, Dmitry. On 26/11/11 12:46, Arno Töll wrote: > Hello Dmitry, > > here is a quick (and incomplete) review: > > * For both, QA and NMUs it is helpful to provide a diff of all changes. > You can use the debdiff tool, or provide a diff of the respective debian > directories at least outlining all your changes. > > * As I mentioned before, you aren't doing a NMU but a QA upload. You set > the maintainer in debian/control correctly, but the version number is > wrong, as is the first line in debian/changelog. This would fix the > following Lintian warnings: > > W: dvbackup source: qa-upload-has-incorrect-version-number 0.0.4rj1-6.2 > W: dvbackup source: changelog-should-mention-qa > > * When closing bugs in debian/changelog you should mention what you have > done and why [1] > > * What's "debian/watch: updated (to help closing #449933)" supposed to > mean? Either you close a bug or you don't. > > * It is no hard requirement, but if you're doing a QA upload and a > package has no public VCS yet, you may consider making one in collab-maint. > > * You should not link the upstream homepage in the package description. > We have our own control field to link that. That would fix these Lintian > warnings [2]: > > I: dvbackup: description-possibly-contains-homepage > http://dvbackup.sourceforge.net/ > P: dvbackup: no-homepage-field > > * Please rebuild the man page from source. Upstream contains both, a > docbook SGML file and its compiled nroff counterpart. However, it looks > like the last time this manpage was processed from its SGML source seems > to have been more than 10 years ago. That yields to these warnings a > modern docbook-to-man processor would fix: > > I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:131 > I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:134 > I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:135 > I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:143 > I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:147 > I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:148 > I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/rsbep.1.gz:141 > > While you're at it, you could also fix: > > I: dvbackup: spelling-error-in-manpage usr/share/man/man1/rsbep.1.gz > completly completely > > * You're installing HTML documentation but you are not registering the > file with doc-base [4]. No clue what's the correct cdbs way to achieve > that ... > However, that addresses this problem: > > I: dvbackup: possible-documentation-but-no-doc-base-registration > > [1] > http://www.debian.org/doc/manuals/developers-reference/pkgs.html#upload-bugfix > [2] > http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Homepage > [3] > http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-desc > [4] http://www.debian.org/doc/debian-policy/ch-opersys.html#s-doc-base > >
diff -Nru dvbackup-0.0.4rj1/debian/changelog dvbackup-0.0.4rj1/debian/changelog --- dvbackup-0.0.4rj1/debian/changelog 2011-11-26 16:07:09.000000000 +1100 +++ dvbackup-0.0.4rj1/debian/changelog 2011-11-26 15:40:54.000000000 +1100 @@ -1,3 +1,22 @@ +dvbackup (0.0.4rj1-7) unstable; urgency=low + + * QA upload + * debian/control + - removed useless recommends (Closes: #488559) + thanks to Justin B Rye <[email protected]> + - fixing spelling in description (Closes: #363355, #557464) + thanks to Simon Waters <[email protected]> + and to Pascal De Vuyst <[email protected]> + - Standards to 3.9.2 + - lintianization + - added autotools-dev to take care of outdated config.(sub|guess) + * debian/watch: updated (related to #449933) + * debian/rules: added support for buildflags + * debian/compat: to 8 + * debian/copyright: minor update + + -- Dmitry Smirnov <[email protected]> Sat, 26 Nov 2011 00:02:15 +1100 + dvbackup (0.0.4rj1-6.1) unstable; urgency=low * NMU. diff -Nru dvbackup-0.0.4rj1/debian/compat dvbackup-0.0.4rj1/debian/compat --- dvbackup-0.0.4rj1/debian/compat 2011-11-26 16:07:09.000000000 +1100 +++ dvbackup-0.0.4rj1/debian/compat 2011-11-26 01:08:49.000000000 +1100 @@ -1 +1 @@ -4 +8 diff -Nru dvbackup-0.0.4rj1/debian/control dvbackup-0.0.4rj1/debian/control --- dvbackup-0.0.4rj1/debian/control 2011-11-26 16:07:09.000000000 +1100 +++ dvbackup-0.0.4rj1/debian/control 2011-11-26 15:58:25.000000000 +1100 @@ -1,19 +1,20 @@ Source: dvbackup Section: admin Priority: extra -Maintainer: Robert Jordens <[email protected]> -Build-Depends: debhelper (>> 4.1.0), cdbs, dh-buildinfo, docbook-to-man, - libpopt-dev, zlib1g-dev -Standards-Version: 3.6.1 +Maintainer: Debian QA Group <[email protected]> +Build-Depends: debhelper (>= 8), cdbs, dh-buildinfo, docbook-to-man, + libpopt-dev, zlib1g-dev, autotools-dev +Standards-Version: 3.9.2 +Homepage: http://dvbackup.sourceforge.net/ http://www.s.netic.de/gfiala/dvbackup.html Package: dvbackup Architecture: any -Depends: ${shlibs:Depends}, libdv-bin (>= 0.99) -Recommends: star | afio | tar (>= 1) | cpio +Depends: ${shlibs:Depends}, ${misc:Depends}, libdv-bin (>= 0.99) +Suggests: star, afio, cpio Description: backup tool using MiniDV camcorders Dvbackup hides the data it receives on standard input in a perfectly legal DV (digital video) stream. This allows you to use your DV camcorder - and your DV cardridges as a potent mass storage system. Obviously, your + and your DV cartridges as a potent mass storage system. Obviously, your system and your camcorder have to be connected via IEEE1394 (aka Firewire, iLink). . @@ -25,16 +26,16 @@ To bring the data on tape, you have to use an additional utility, called dvconnect, which is included in libdv-bin. . - This packages also contains rsbep, an implementation of a special version of + This package also contains rsbep, an implementation of a special version of the Reed-Solomon FEC (forward error correction) algorithm. rsbep also spreads the bytes of the resulting blocks out to give some protection against burst errors (e.g from tape-recordings). It should be used in a pipe together with dvbackup (before dvbackup while encoding and after it while decoding). rsbep should be sufficient to make the LP mode of your camcorder usable. This mode, which puts about 50% more data - on the cardridge would otherwise be too error-prone. rsbep is the + on the cartridge would otherwise be too error-prone. rsbep is the fast implementation in i386 assembler, rsbepC uses pure C and is significantly slower (about ten times). . - Website: <http://dvbackup.sourceforge.net/> and - <http://www.s.netic.de/gfiala/rsbep.html>. + Website: < and + <>. diff -Nru dvbackup-0.0.4rj1/debian/copyright dvbackup-0.0.4rj1/debian/copyright --- dvbackup-0.0.4rj1/debian/copyright 2011-11-26 16:07:09.000000000 +1100 +++ dvbackup-0.0.4rj1/debian/copyright 2011-11-26 01:22:16.000000000 +1100 @@ -7,22 +7,20 @@ Upstream Authors: Peter Schlaile <[email protected]> and Guido Fiala <[email protected]> -Copyright: +Copyright: 2001 Peter Schlaile <[email protected]> + 2000 Guido Fiala <[email protected]> -This program is free software; you can redistribute it and/or modify it -under the terms of the GNU General Public License as published by the -Free Software Foundation; either version 2 of the License, or (at your -option) any later version. - -This program is distributed in the hope that it will be useful, but -WITHOUTANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -General Public License for more details. - -You should have received a copy of the GNU General Public License along -with this program; if not, write to the Free Software Foundation, Inc., -59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. - -On Debian systems, the complete text of the GNU General Public License -can be found in /usr/share/common-licenses/GPL file. +License: + This program is free software; you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by the + Free Software Foundation; either version 2 of the License, or (at your + option) any later version. + . + This program is distributed in the hope that it will be useful, but + WITHOUTANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + . + On Debian systems, the complete text of the GNU General Public License + version 2 can be found in /usr/share/common-licenses/GPL-2 diff -Nru dvbackup-0.0.4rj1/debian/rules dvbackup-0.0.4rj1/debian/rules --- dvbackup-0.0.4rj1/debian/rules 2011-11-26 16:07:09.000000000 +1100 +++ dvbackup-0.0.4rj1/debian/rules 2011-11-26 01:37:58.000000000 +1100 @@ -8,6 +8,9 @@ # # $Id: rules 240 2004-01-17 16:53:09Z rj $ +# see http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html +# Also it does hardening by default, see http://wiki.debian.org/Hardening +-include /usr/share/dpkg/default.mk include /usr/share/cdbs/1/class/makefile.mk DEB_UPSTREAM_VERSION := $(shell echo $(DEB_VERSION) | sed 's/-[^-]*//') diff -Nru dvbackup-0.0.4rj1/debian/source/format dvbackup-0.0.4rj1/debian/source/format --- dvbackup-0.0.4rj1/debian/source/format 1970-01-01 10:00:00.000000000 +1000 +++ dvbackup-0.0.4rj1/debian/source/format 2011-11-10 14:56:25.000000000 +1100 @@ -0,0 +1 @@ +3.0 (quilt) diff -Nru dvbackup-0.0.4rj1/debian/watch dvbackup-0.0.4rj1/debian/watch --- dvbackup-0.0.4rj1/debian/watch 2011-11-26 16:07:09.000000000 +1100 +++ dvbackup-0.0.4rj1/debian/watch 2011-11-26 15:43:03.000000000 +1100 @@ -1,2 +1,7 @@ -version=2 -ftp://ftp.sf.net/d/dv/dvbackup/dvbackup-(.*)\.tar\.gz debian uupdate +version=3 +http://sf.net/dvbackup/dvbackup-(.*)\.tar\.gz +#http://www.s.netic.de/gfiala/dvbackup.html rsbep([\d\.]+).tgz + +# This packages combine dvbackup from dvbackup.sf.net +# and rsbep from http://www.s.netic.de/gfiala/dvbackup.html +# so tracking upstream is not possible with uscan, see #449933
