Hi Mike, On Sun, May 06, 2012 at 06:04:17PM -0400, Michael Gilbert wrote: > I just reviewed this package. It looks good except for a couple issues:
Thanks for taking a look at this. > 1. bin/credits.rpl seems to be a binary file in the repacked upstream > source (there may be others, but I stopped at that one) Apart from the various .ogg files and the .ttf files for DejaVu, that's the only binary left. It's a replay of a level in the game, so there is no appropriate form for modification - it was recorded using the game and is not generated... > 2. I'm not sure that it's good practice to apply the patch directly > within the upstream orig file. It would be better to do that via > quilt. You probably did that to make sure that the orig would be > buildable by itself, but that isn't necessary. That is indeed why I did it. I'll fix it once I get wine-gecko done! Regards, Stephen -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
