Another round of feedback, from in-person review at pycon.za: = debian/changelog = * There is missing a blank line above the first line of the top changelog entry. * And I see some trailing whitespace. * The changelog entry for your upload only has a single line, it should say (in not necessarily extensive, but broad detail) what you've done.
= debian/control = * There are long dependency lines. You can tidy these up with wrap-and-sort (or even wrap-and-sort -s, which I like) * We're up to Standards-Version 3.9.6 now. The build fails, immediately. More seriously, it looks like you based your package on some unknown source, that I can't place. Which makes it really hard for me to see what to review. I suggest grabbing the latest Debian upload, 0.9.0+dfsg2-1, and re-basing your changes onto that. You can probably get it from the team SVN repo (as mentioned in the control file). Or from the latest upload to the archive: * In an unstable chroot/VM run apt-get source freemind. * Or maybe install ubuntu-dev-tools and run pull-debian-source freemind. SR -- Stefano Rivera http://tumbleweed.org.za/ H: +27 21 461 1230 C: +27 72 419 8559 -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: https://lists.debian.org/[email protected]
