Well, 5 minutes review:

1)control:

a)

+Maintainer: Guilhem Moulin <[email protected]>
+Uploaders: Gerrit Pape <[email protected]>,


I would do the opposite, but well, as you wish :)

b)

dh-autoreconf, autoconf, automake (>= 1:1.12)

I think dh-autoreconf is already enough, but please double check (I didn't test 
a build)


2)changelog: changes are huge, maybe urgency=low might be more appropriate (or 
experimental)


3)copyright: with upstream MIT, and you GPL-2 or GPL-3, it becomes impossible 
to forward patches
to them.

Do you have any good reason for using a different license?

the other stuff looks good, but for sure I need to build and test it :)

cheers,

G.




Il Lunedì 21 Settembre 2015 16:53, Gianfranco Costamagna 
<[email protected]> ha scritto:
Hi Helmut, Gerrit gave him permission to comaintain, do you want to followup 
with the review?

I can do a review in the next 2-3 days if needed,

cheers,

G.





Il Domenica 20 Settembre 2015 14:45, Guilhem Moulin <[email protected]> ha 
scritto:
Hi Helmut & Gianfranco,

By the way if you don't have time or are no longer interested in
sponsoring this upload (which is no longer an NMU by the way) please
just say it out loud so I can poke [email protected] again :-)

Thanks!

Cheers,
-- 
Guilhem.

Reply via email to