Your message dated Mon, 16 Apr 2018 20:59:17 +0000
with message-id <e1f8bdz-000j2l...@fasolo.debian.org>
and subject line Bug#895659: fixed in gutenprint 5.3.0~pre1-3
has caused the Debian Bug report #895659,
regarding gutenprint: please stop using --ignore debhelper option
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
895659: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895659
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: gutenprint
Version: 5.3.0~pre1-2
Severity: wishlist
Tags: patch

Hello.

Debhelper is considering deprecating the --ignore option.
It is used once in gutenprint.

Commit 5b3f43f1 stops installing the usb directory on non Linux architectures.
Among other changes, it moves "usr/share/cups/usb" from
debian/printer-driver-gutenprint.install to the freshly created
debian/printer-driver-gutenprint.install.linux.
The intent was probably that both files are used when
DEB_HOST_ARCH_OS=linux, else only the first one.

This does not work because debhelper only considers the most specific file.
Commit 49ffeb1f fixes this in debian/rules by adding:
  ifeq ($(DEB_BUILD_ARCH_OS),linux)
        # Install common files
        dh_install -pprinter-driver-gutenprint 
--ignore=debian/printer-driver-gutenprint.install.linux
  endif
right before
        dh_install -a

The effect is that
* on linux, the first dh_install run installs normal files,
  and the second run installs the usb directory.
* on other architectures, dh_install is only run once and installs the
  normal files.

If all this is correct, the attached patch should have the same effect
in a more readable way, and without --ignore.

Thanks.
--- a/debian/printer-driver-gutenprint.install.linux
+++ /dev/null
@@ -1 +0,0 @@
-usr/share/cups/usb
--- a/debian/rules
+++ b/debian/rules
@@ -38,10 +38,9 @@ override_dh_clean:
 
 override_dh_install-arch:
 ifeq ($(DEB_BUILD_ARCH_OS),linux)
-	# Install common files
-	dh_install -pprinter-driver-gutenprint --ignore=debian/printer-driver-gutenprint.install.linux
+	dh_install -pprinter-driver-gutenprint usr/share/cups/usb
 endif
-	dh_install -a
+	dh_install -a --remaining-packages
 # Remove rpath
 	find debian/printer-driver-gutenprint/usr/lib -type f -perm /0111 -print0 | xargs -0 chrpath --delete
 # Install ppd-updater file

--- End Message ---
--- Begin Message ---
Source: gutenprint
Source-Version: 5.3.0~pre1-3

We believe that the bug you reported is fixed in the latest version of
gutenprint, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 895...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Didier Raboud <o...@debian.org> (supplier of updated gutenprint package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 16 Apr 2018 22:35:58 +0200
Source: gutenprint
Binary: gimp-gutenprint printer-driver-gutenprint libgutenprint-dev 
libgutenprint-doc libgutenprint9 libgutenprint-common libgutenprintui2-dev 
libgutenprintui2-2 gutenprint-locales escputil gutenprint-doc
Architecture: source
Version: 5.3.0~pre1-3
Distribution: experimental
Urgency: medium
Maintainer: Debian Printing Group <debian-printing@lists.debian.org>
Changed-By: Didier Raboud <o...@debian.org>
Description:
 escputil   - maintenance utility for Epson Stylus printers
 gimp-gutenprint - print plugin for the GIMP
 gutenprint-doc - users' guide for Gutenprint and CUPS
 gutenprint-locales - locale data files for Gutenprint
 libgutenprint-common - support files for the Gutenprint printer driver library
 libgutenprint-dev - development files for the Gutenprint printer driver library
 libgutenprint-doc - documentation for the Gutenprint printer driver library
 libgutenprint9 - runtime for the Gutenprint printer driver library
 libgutenprintui2-2 - runtime for the Gutenprint printer driver user interface 
library
 libgutenprintui2-dev - development files for the Gutenprint printer driver 
user interfac
 printer-driver-gutenprint - printer drivers for CUPS
Closes: 895659
Changes:
 gutenprint (5.3.0~pre1-3) experimental; urgency=medium
 .
   [ Didier Raboud ]
   * Bump S-V to 4.1.4 without changes needed
   * Drop end-of-line whitespace
   * Rewrite debian/copyright thanks to `cme update dpkg-copyright`
 .
   [ Nicolas Boulenguez ]
   * Rewrite ARCH_OS-different installation to avoid the use of debhelper's 
--ignore
     (Closes: #895659)
Checksums-Sha1:
 0b7eaceb67236d776ccd631f81ec33165dce1747 2829 gutenprint_5.3.0~pre1-3.dsc
 0f3a2cc152df00a3029daddd28fb9d5f5019b658 89736 
gutenprint_5.3.0~pre1-3.debian.tar.xz
Checksums-Sha256:
 bee63de1f94654f8ca298e6c2714874ee8bab07333a5c652af68463ea974cef6 2829 
gutenprint_5.3.0~pre1-3.dsc
 36e95520eba2681681925cf0ad366cbf90a3ffca231f54bc66d1e7b1dafeb7d5 89736 
gutenprint_5.3.0~pre1-3.debian.tar.xz
Files:
 7a8faf13cbcef42099707ca946c77be7 2829 graphics optional 
gutenprint_5.3.0~pre1-3.dsc
 227562a85ed9093d05990b30994ed949 89736 graphics optional 
gutenprint_5.3.0~pre1-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEe+WPIRpjNw1/GSB7i8+nHsoWNFUFAlrVChoACgkQi8+nHsoW
NFU6wgv9Hj1rHxQ0dSDCqH3sIGEsQXmIdDjf4KaL5+6PqRFr0JHoLKJM430CQnXh
53pBYyhJhLTNOgF0j4XBK0IZRETvMc9abtedJ3VSVbs6J5Wr28wYM8L1o5bAw10O
MlTJWngZyC0TYuP+NOYp6k+EJjUvba16xprVO/ubGuWGbsslu+QJ22V6kJZZIxe3
gIx40ivF1ES7187xoKOiIqgrjCuZQna7sLCc8/TI1nmwAF33NHi8NWa/r9hLJ3lM
Oqg5QHg64rAeKSK+iUudrFJkDe8yu4S1sYPS1ntWVS4sk8ceyruz1S3coXMHk0oz
jxK0t8n2iB5rm0eKHhl2cwIhR/U1bU4ionaTJYuxkC7S7tl0cs8GRCojvHOVzw7m
YGHj+b9WcRD0aW/mVF6eORhjzmQu61t0i6giDDzYrKM4qS4dqq/jgGlyWas+hIl4
RUhcRbfdd72oODxwGgI7DcV4jyszWPmYkeNu5QaP/VYV8ISnRrUU0v2oZjZ+t3ke
LKtoWIZ+
=QXTn
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to