Bonjour Antoine,I already discussed this topic with you in IRC, but I'm documenting the details here for the sake of the mailing list.
* i wonder if bumblebee-status/_version.py belongs there. it's a copy
of the python3-versioneer package that's already in the
archive... could you remove it from the source and make sure we use
the Debian copy instead? at the very least the debian/copyright file
should refer to it...
_version.py is not a copy of versioneer, it's *generated* by versioneer. However, there is versioneer.py in the root directory, which is. I'll exclude that from the source and repack.
* i also attach the output of `decopy` which finds a few more things
than you in debian/copyright
* i'm really not sure I like that C binary to fetch the keyboard
layout... surely there must be a more pythonic way of doing this? i
guess there's another layout-xkb module that does the right thing,
but it seems odd to have both there.. you also seem to rebuild it in
debian/rules, but i don't see where it gets installed
I'm just following what was done upstream (except removing a prebuilt binary in the source that I then rebuild).
As for how it's installed, I believe that's handled by the upstream setup.py:
data_files=[
("share/bumblebee-status/themes", glob.glob("themes/*.json")),
("share/bumblebee-status/themes/icons",
glob.glob("themes/icons/*.json")),
("share/bumblebee-status/utility", glob.glob("bin/*")),
]
Looks like it's put into /something/share/bumblebee-status/utility.
One flaw I did find is that my package is marked for architecture all,
while in reality it should be marked as any because of this C binary.
* i did a quick read of most of the code in commit
30853fd19110c6e53be35c4bb846ab3a133b51ac and it seems sane. i haven't
reviewed the contrib modules
* the build fails here, in a fresh Debian unstable qemu image, with:
ERROR tests/core/test_output.py - RuntimeError: unable to find theme
default
I am aware of this failure and have reported it upstream. For now, I'll disable the offending test.
I attach a full build log. Thanks for working on this package! a. anarcat@curie:bumblebee-status$ decopy Building tree: 56dir [00:00, 2629.63dir/s] Queueing: 739file [00:00, 1586.90file/s] Processing: 100%|██████████████████████████████| 683/683 [00:10<00:00, 63.52file/s] Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: bumblebee-status Upstream-Contact: tobi-wan-kenobi Source: https://github.com/tobi-wan-kenobi/bumblebee-status Files-Excluded: bin/get-kbd-layout Comment: Removed x86_64 Linux binary with source available in the same repo Files: * Copyright: 2015, Marc Herndon and GPL2 2017, Oscar Svensson 2017, Oscar Svensson (wogscpar) under MIT licence from upower-python Public Domain License: Expat or MIT Files: LICENSE Copyright: 2016, tobi-wan-kenobi License: Expat Files: bumblebee_status/_version.py License: public-domain Files: debian/* Copyright: 2022, Ben Westover <kwestover...@gmail.com> License: MIT License: Expat Comment: Add the corresponding license text here License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. License: public-domain Comment: Add the corresponding license text here
This autogenerated copyright file has some problems. First of all, LICENSE shouldn't be considered separate from the rest of the source, since it describes the entire source. Also, as far as Debian is concerned, MIT and Expat are the same license (although in reality MIT is a term used to describe two slightly different licenses). The copyright holder for * is incorrect, I don't know where it got that info from. It did catch _version.py, which I didn't, so I'll add that.
Merci d'avoir examiné mon paquet, -- Ben Westover
OpenPGP_signature
Description: OpenPGP digital signature
