Hello Arif, I took avocado from #debian-python irc topic. Thanks for your contributions to Debian!
Please read my following reviews:
- Tests are failing
unit-126-selftests/unit/runner_package.py:ActionTests.test_success_install: FAIL
unit-127-selftests/unit/runner_package.py:ActionTests.test_already_installed:
FAIL
unit-129-selftests/unit/runner_package.py:ActionTests.test_success_remove: FAIL
unit-131-selftests/unit/runner_package.py:ActionTests.test_fail_remove: FAIL
unit-132-selftests/unit/runner_package.py:ActionTests.test_success_check: FAIL
make[1]: *** [debian/rules:13: override_dh_auto_test] Error 1
- you can use profile <!nodoc> for those b-dependency used only for
documentation
- what about move d/watch to version 5?
- What about adding a manual page?
- d/copyright: aroud line 120 the license you are describing should be one per
stanza, I mean don't use expat and/or gpl-2+. You should declare one of them,
and then othe other. Lintian says: W: avocado source:
space-in-std-shortname-in-dep5-copyright expat and/or gpl-2+
[debian/copyright:88]
- What about update Standard-Version?
- Do you try build package with pybuild-plugin-pyproject?
Please, let me know whe you have a new version to review.
--
cheers,
Emmanuel Arias
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ [email protected]
⢿⡄⠘⠷⠚⠋⠀ OpenPGP: 13796755BBC72BB8ABE2AEB5 FA9DEC5DE11C63F1
⠈⠳⣄
signature.asc
Description: PGP signature
