Hey Emmanuel. Thank you for reviewing, it's very much appreciated. Below are the answers to your questions
- Tests are failing > unit-126-selftests/unit/runner_package.py:ActionTests.test_success_install: > FAIL > unit-127-selftests/unit/runner_package.py:ActionTests.test_already_installed: > FAIL > unit-129-selftests/unit/runner_package.py:ActionTests.test_success_remove: > FAIL > unit-131-selftests/unit/runner_package.py:ActionTests.test_fail_remove: > FAIL > unit-132-selftests/unit/runner_package.py:ActionTests.test_success_check: > FAIL > make[1]: *** [debian/rules:13: override_dh_auto_test] Error 1 > These are new failures, as they were passing when I originally asked for RFS. This RFS has been on-ongoing for almost a year now. I will investigate the failures and follow up with a new working upload - you can use profile <!nodoc> for those b-dependency used only for > documentation Noted > - what about move d/watch to version 5? > As mentioned above, this has been out there for almost a year, when version 5 was new. I can investigate, and complete that for the next upload > - What about adding a manual page? > There was no man page upstream, and upstream are only doing RPM packages, I needed this package for Testing of another package I maintain, I decided to package it myself. If man-page is mandatory, then I can get something up > - d/copyright: aroud line 120 the license you are describing should be one > per > stanza, I mean don't use expat and/or gpl-2+. You should declare one of > them, > and then othe other. Lintian says: W: avocado source: > space-in-std-shortname-in-dep5-copyright expat and/or gpl-2+ > [debian/copyright:88] > When I had that, I had different lintian warnings, but happy to accomodate your suggestion > - What about update Standard-Version? > Same as above; I will address this with my next upload, as this has been on-going for a year > - Do you try build package with pybuild-plugin-pyproject? > I haven't tried yet, but I will have a go. regards, Arif
