hi Lester,

I took a look at the python-asn1tools package, up for sponsorship in
the Python team:

* copyright: missing info for:
  examples/benchmarks/c_source/asn1c/generated/*  (Lev Walkin and/or
  X/IO Labs, xiolabs.com; under some to-be-determined form of BSD)

* control: synopsis could be improved, see [1].
* control: no dependencies on the binary pkg for optional imports,
  i.e. on python3-prompt-toolkit and python3-diskcache; Even if the
  upstream code handles fines with these missing, you could still add
  a recommends or suggests to enable optional feature or simply as a
  hint to end users.

* manpage: created by help2man; it's usually better to generate on
  build than ship a static copy. That way everything remains
  up-to-date when future upstream releases get packaged, where a
  static copy inevitably ends up going stale.

  Numerous examples may be found via [2].

* d/gbp.conf: this feels like AI slop. Please clean up and refrain
  from hardcoding options to unsafe defaults in team-maintained
  packages.

* rules: PYBUILD_AFTER_TEST would benefit from globbing and/or
  multiline formatting to avoid excessive line length.


[1]https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.en.html#the-package-synopsis-or-short-description
[2]https://codesearch.debian.net/search?q=path%3Adebian%2Frules%20help2man&literal=1&perpkg=1


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

Attachment: pgpaXbFk8LAPr.pgp
Description: OpenPGP digital signature

Reply via email to