Hi Jeroen, Thanks for the review.
* copyright: missing info for: examples/benchmarks/c_source/asn1c/generated/* (Lev Walkin and/or X/IO Labs, xiolabs.com; under some to-be-determined form of BSD)
I have added the files to d/copyright. There's no consistent copyright year or range in these files, so I split then grouped them into separate stanzas according to unique copyright years. I hope that's the right approach here.
* control: synopsis could be improved, see [1].
The synopsis and the long description are much better now, I think.
* control: no dependencies on the binary pkg for optional imports, i.e. on python3-prompt-toolkit and python3-diskcache; Even if the upstream code handles fines with these missing, you could still add a recommends or suggests to enable optional feature or simply as a hint to end users.
Thanks for the hint. I have added both as recommends.
* manpage: created by help2man; it's usually better to generate on build than ship a static copy. That way everything remains up-to-date when future upstream releases get packaged, where a static copy inevitably ends up going stale. Numerous examples may be found via [2].
Done, manpage is now generated on the fly instead of a static copy in debian/.
* d/gbp.conf: this feels like AI slop. Please clean up and refrain from hardcoding options to unsafe defaults in team-maintained packages.
It is indeed :-) I updated it to what I normally use in my other packages.
* rules: PYBUILD_AFTER_TEST would benefit from globbing and/or multiline formatting to avoid excessive line length.
Done. Thanks again. -- Regards, Lester [email protected] OpenPGP: 107B6026A82D044C97D7D8B92100C145E0F3655E
OpenPGP_signature.asc
Description: OpenPGP digital signature
