hi Lester, I reviewed the python-asysocks package, up for sponsorship in the Python team. While the changes in revision -2 itself are tiny and unproblematic, there are several issues that already affect the previous revision and really need attention:
* no tests are run on build, despite the presence of test-only build-dependencies and a patch dealing with the upstream testsuite. You may have to instruct pybuild where to find the tests and/or how to run them. * d/control sets 'Testsuite: autopkgtest-pkg-pybuild' but unless and until tests are actually run on build, that won't do anything but pretend the package comes with an autopkgtest. * the package appears to be missing a number of module dependencies for unconditional imports throughout the code, including wsnet, websockets, tqdm, mbedtls, asyauth, and aioquic. There would be crashes and tracebacks as soon as any of the affected codepaths were hit. * examples get installed in two locations; the duplicate files are in /usr/share/doc/python3-asysocks/examples/ and /usr/lib/python3/dist-packages/asysocks/examples/ Are the examples supposed to make up a part of the module? If not, you could simply remove the examples under dist-packages. I'm including the sponsor of the initial upload in the CC, maybe they'll be able to shed some light on things. Once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail.
pgp6Yh2ik2vKh.pgp
Description: OpenPGP digital signature
