Package: release.debian.org Severity: normal User: [email protected] Usertags: pu
Hi, I'd like to fix a crash in krb5-auth-dialog that affects at least Debian Edu badly (#714825). Debdiff is attached. O.k. to uplaod to s-p-u? Cheers, -- Guido -- System Information: Debian Release: jessie/sid APT prefers stable APT policy: (990, 'stable'), (500, 'testing'), (50, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 3.9-1-686-pae (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru krb5-auth-dialog-3.2.1/debian/changelog krb5-auth-dialog-3.2.1/debian/changelog --- krb5-auth-dialog-3.2.1/debian/changelog 2011-11-03 19:46:58.000000000 +0100 +++ krb5-auth-dialog-3.2.1/debian/changelog 2013-07-05 18:01:42.000000000 +0200 @@ -1,3 +1,10 @@ +krb5-auth-dialog (3.2.1-1+deb7u1) stable-proposed-updates; urgency=low + + * [7b5a095] Fix krb5_principal_compare crashes on NULL arguments. + Thanks to Petter Reinholdtsen (Closes: #714825) + + -- Guido Günther <[email protected]> Fri, 05 Jul 2013 17:58:44 +0200 + krb5-auth-dialog (3.2.1-1) unstable; urgency=low * [325b5a9] New upstream version 3.2.1 diff -Nru krb5-auth-dialog-3.2.1/debian/patches/0001-krb5_principal_compare-crashes-on-NULL-arguments.patch krb5-auth-dialog-3.2.1/debian/patches/0001-krb5_principal_compare-crashes-on-NULL-arguments.patch --- krb5-auth-dialog-3.2.1/debian/patches/0001-krb5_principal_compare-crashes-on-NULL-arguments.patch 1970-01-01 01:00:00.000000000 +0100 +++ krb5-auth-dialog-3.2.1/debian/patches/0001-krb5_principal_compare-crashes-on-NULL-arguments.patch 2013-07-05 17:58:25.000000000 +0200 @@ -0,0 +1,26 @@ +From: Petter Reinholdtsen <[email protected]> +Date: Thu, 4 Jul 2013 09:32:18 +0200 +Subject: krb5_principal_compare crashes on NULL arguments + +Debian Bug #714825 +--- + src/ka-kerberos.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/src/ka-kerberos.c b/src/ka-kerberos.c +index db5cddd..0867234 100644 +--- a/src/ka-kerberos.c ++++ b/src/ka-kerberos.c +@@ -221,8 +221,10 @@ credentials_expiring_real (KaApplet *applet) + } + + /* copy principal from cache if any */ +- if (krb5_principal_compare (kcontext, my_creds.client, kprincipal)) { +- krb5_free_principal (kcontext, kprincipal); ++ if (kprincipal == NULL || ++ krb5_principal_compare (kcontext, my_creds.client, kprincipal)) { ++ if (kprincipal) ++ krb5_free_principal (kcontext, kprincipal); + krb5_copy_principal (kcontext, my_creds.client, &kprincipal); + } + creds_expiry = my_creds.times.endtime; diff -Nru krb5-auth-dialog-3.2.1/debian/patches/series krb5-auth-dialog-3.2.1/debian/patches/series --- krb5-auth-dialog-3.2.1/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ krb5-auth-dialog-3.2.1/debian/patches/series 2013-07-05 17:58:25.000000000 +0200 @@ -0,0 +1 @@ +0001-krb5_principal_compare-crashes-on-NULL-arguments.patch
