Package: release.debian.org Severity: normal Tags: jessie User: release.debian....@packages.debian.org Usertags: pu
Hello, first of all, reportbug lists only squeeze and wheezy when making a pu-related bug report. I'd like to request to upload a bug-fix for the roger-router package to Jessie. This would fix bugs #798471 and #774116. Roger Router is a tool to interact with Fritzbox hardware from AVM. One of the things it can do is to send a fax. This was broken until version 1.8.9-3 because compilation happened as --with-cups-yes assuming this would include cups-support when in fact this disabled a known-good code base for cups-support and replaced it with a known-broken, experimental one. The patches are cherry-picked from 1.8.9-3 and 1.8.9-4. I'd like to ship alongside some improvements in the README.Debian file to guide the user in case they run into problems. These changes should have little risk of regression and improve the user experience for stable customers considerably. Looking forward to your comments. Regards Rolf Leggewie
>From 67bc92d83524ebce8c3c0253d19e509c2556e2ce Mon Sep 17 00:00:00 2001 From: Rolf Leggewie <f...@rolf.leggewie.biz> Date: Sat, 8 Nov 2014 22:59:00 +0800 Subject: [PATCH 1/4] do not build the experimental (!) cups backend. Closes: #798471, Closes: #774116 OMG. the compilation switch "--with-cups" doesn't mean what you'd expect. It means "build the experimental, known-broken, WIP (!) version of cups-support", and disable the standard, working cups backend. Who in their right mind would expect that kind of semantic? Of course, upstream didn't document this anywhere. Grr! --- debian/control | 2 -- debian/libroutermanager0.symbols | 2 +- debian/roger-router-cli.install | 3 +-- debian/rules | 3 +-- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/debian/control b/debian/control index a1df6d4..b660a8f 100644 --- a/debian/control +++ b/debian/control @@ -6,9 +6,7 @@ Uploaders: Jan-Michael Brummer <jan.brum...@tabos.org> Build-Depends: debhelper (>= 9), dh-autoreconf, libappindicator3-dev, libcapi20-dev (>= 1:3.24), - libcups2-dev, libebook1.2-dev, - libgconf2-dev, libgstreamer1.0-dev, libgstreamer-plugins-base1.0-dev, libgtk-3-dev, libnotify-dev, diff --git a/debian/libroutermanager0.symbols b/debian/libroutermanager0.symbols index 1d29ec1..7e302d9 100644 --- a/debian/libroutermanager0.symbols +++ b/debian/libroutermanager0.symbols @@ -81,7 +81,7 @@ libroutermanager.so.0 libroutermanager0 #MINVER# fax_send@Base 1.8.4 fax_set_log_level@Base 1.8.4 fax_spandsp_workaround@Base 1.8.4 - fax_spooler_new_dir_cb@Base 1.8.4 +#MISSING: 1.8.9-2# fax_spooler_new_dir_cb@Base 1.8.4 fax_transfer@Base 1.8.4 faxophone_close@Base 1.8.4 faxophone_connect@Base 1.8.4 diff --git a/debian/roger-router-cli.install b/debian/roger-router-cli.install index d8d4c6b..1379a1c 100644 --- a/debian/roger-router-cli.install +++ b/debian/roger-router-cli.install @@ -1,8 +1,7 @@ usr/bin/roger_cli usr/lib/*/routermanager/ -usr/lib/cups/backend/roger-cups usr/share/man/*/roger_cli* -usr/share/roger/roger-cups +usr/share/roger/roger-cups usr/lib/cups/backend/ usr/share/roger/roger-fax.ppd usr/share/roger/install-fax.sh diff --git a/debian/rules b/debian/rules index 95b94a1..c7c5f2f 100755 --- a/debian/rules +++ b/debian/rules @@ -13,7 +13,6 @@ override_dh_auto_configure: dh_auto_configure -- \ --with-spandsp=6 \ --with-libnotify=yes \ - --with-cups=yes \ --with-secret=yes \ --with-ebook=yes \ --with-gstreamer1=yes \ @@ -32,7 +31,7 @@ override_dh_install: override_dh_fixperms: dh_fixperms - chmod 755 debian/roger-router-cli/usr/share/roger/roger-cups chmod 755 debian/roger-router-cli/usr/share/roger/install-fax.sh + chmod 755 debian/roger-router-cli/usr/lib/cups/backend/roger-cups chown lp.fax debian/roger-router-cli/var/spool/roger chmod 2770 debian/roger-router-cli/var/spool/roger -- 1.9.1
>From ad80ff407b739f4975325fce7524dbe4ed740c86 Mon Sep 17 00:00:00 2001 From: Rolf Leggewie <f...@rolf.leggewie.biz> Date: Sat, 7 Mar 2015 15:39:51 +0800 Subject: [PATCH 2/4] README.Debian: add some information on how to send a fax --- debian/README.Debian | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/debian/README.Debian b/debian/README.Debian index 13996bd..8bb1f9f 100644 --- a/debian/README.Debian +++ b/debian/README.Debian @@ -1,3 +1,5 @@ += Configuration = + configuration help is available from http://wiki.ubuntuusers.de/FritzBox/Roger_Router @@ -8,8 +10,15 @@ http://en.tabos.org/installation-prequel If you want to use the incoming call notification you will have to enable it on your fritzbox with: #96*5* +Please note, quick reconnect & display external ip in tooltip for Fritz!Box +needs active UPnP support! + += Fax support = + If you want to use the capifax plugin you will have to enable capi-over-tcp on your fritzbox with: #96*3* -Please note, quick reconnect & display external ip in tooltip for Fritz!Box -needs active UPnP support! +Roger installs a Cups printer. To be able to fax, you either need to use +roger_cli where you specify all necessary information including the number +to send to on the command line or you should have Roger GUI running and it +will prompt you for the receiving Fax number. -- 1.9.1
>From a532eb4b1b58ed0d5f33265b7ff8c17c47d42875 Mon Sep 17 00:00:00 2001 From: Rolf Leggewie <f...@rolf.leggewie.biz> Date: Thu, 12 Mar 2015 09:58:52 +0800 Subject: [PATCH 3/4] README.Debian: add information what needs to be done after firmware updates --- debian/README.Debian | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/debian/README.Debian b/debian/README.Debian index 8bb1f9f..7a06d73 100644 --- a/debian/README.Debian +++ b/debian/README.Debian @@ -8,16 +8,16 @@ http://forum.ubuntuusers.de/topic/roger-router-roger/ http://en.tabos.org/installation-prequel If you want to use the incoming call notification you will have to enable -it on your fritzbox with: #96*5* +it on your fritzbox with: #96*5* If you want to use the capifax plugin +you will have to enable capi-over-tcp on your fritzbox with: #96*3* Both +of these settings will be reset to their default value of "off" whenever +you update the router firmware. Please reenable them as necessary. Please note, quick reconnect & display external ip in tooltip for Fritz!Box needs active UPnP support! = Fax support = -If you want to use the capifax plugin you will have to enable capi-over-tcp -on your fritzbox with: #96*3* - Roger installs a Cups printer. To be able to fax, you either need to use roger_cli where you specify all necessary information including the number to send to on the command line or you should have Roger GUI running and it -- 1.9.1
>From 66406436afc9ef2904603616e123d4751dd17968 Mon Sep 17 00:00:00 2001 From: Rolf Leggewie <f...@rolf.leggewie.biz> Date: Mon, 4 Apr 2016 15:17:38 +0200 Subject: [PATCH 4/4] WIP changelog --- debian/changelog | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/debian/changelog b/debian/changelog index f02d242..8d579d5 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,19 @@ +roger-router (1.8.9-2jessie1) jessie; urgency=medium + + backport fixes to fax support from 1.8.9-3 and 1.8.9-4 + + * do not build the experimental (!) cups backend. Closes: #774116 + Upstream uses a very funny (NOT!) semantics to their make-switches. + Who would expect that "--with-cups=yes" actually DISABLES a working + cups support? + * README.Debian: + - add some information on how to send a fax + - add information what needs to be done after firmware updates + certain functions, such as fax support, will be reset to being + disabled every time a new firmware is installed + + -- Rolf Leggewie <f...@rolf.leggewie.biz> Mon, 04 Apr 2016 15:14:08 +0200 + roger-router (1.8.9-2) unstable; urgency=low * copyright: add copyright information for win32/printer/ghostpdf.ppd -- 1.9.1
