[Hanno Zulla] > Hi, > > I'm new at this, so please be patient with my first packaging attempts. > > ruby-hamster 2.0.0-1 > > needs a review. This gem is a dependency of the Sonic Pi application, > which I am preparing for Debian.
I had a look, and the package build just fine in my sid chroot. I noticed a few issues. - You should list yourself and perhaps others as uploaders. - The license of debian/* (GPL-2.0+) and the rest of the package () differ and patches in debian/patches/* would need to be relicensed before they can go upstream. Is this intentional? - One of the patches is missing the Applied-Upstream header. - How did you figure out the copyright of the package? The only trace I could find of a license for the package is in metadata.yml, stating "licenses: - MIT". Why do you believe it is Expat licensed? Once the uploader list is fixed, the lintian warnings go away. I would be happy to sponsor this upload too, unless someone knowing ruby more than me protests. -- Happy hacking Petter Reinholdtsen
