Your message dated Thu, 09 Apr 2020 14:59:33 +0000
with message-id <[email protected]>
and subject line Bug#956254: fixed in orocos-kdl 1.4.0-9
has caused the Debian Bug report #956254,
regarding python3-pykdl: PyKDL crashes Python 3 interpretter (SIGABRT) if any 
API accepting a str is used
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
956254: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956254
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python3-pykdl
Version: 1.4.0-7
Severity: important
Tags: patch

Dear Maintainer,


The package python3-pykdl crashes the Python 3 interpretter if any API
accepting a str is used. I've tested this in both Debian Buster and Sid.

$ python3 -c "import PyKDL; PyKDL.Tree('foobar')"
python3: 
/build/orocos-kdl-oHbJfL/orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip:52:
 int convertTo_std_string(PyObject*, void**, int*, PyObject*): Assertion 
`PyUnicode_Check(s)' failed.
Aborted (core dumped)
$ echo $?
134

The following patch resolves the issue on both Buster (1.4.0-7) and Sid
(1.4.0-8)


Index: orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip
===================================================================
--- orocos-kdl-1.4.0.orig/python_orocos_kdl/PyKDL/std_string.sip
+++ orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip
@@ -48,9 +48,7 @@
          return 1;
      }
      if (PyUnicode_Check(sipPy)) {
-        PyObject* s = PyUnicode_AsEncodedString(sipPy, "UTF-8", "");
-        *sipCppPtr = new std::string(PyUnicode_AS_DATA(s));
-        Py_DECREF(s);
+        *sipCppPtr = new std::string(PyUnicode_AsUTF8(sipPy));
         return 1;
      }
 #if PY_MAJOR_VERSION < 3


Would you be willing to apply that patch and release a new version to
Buster and Sid?


Cheers,
Shane


-- System Information:
Debian Release: 10.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.3.0-45-generic (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages python3-pykdl depends on:
ii  libc6             2.28-10
ii  libgcc1           1:8.3.0-6
ii  liborocos-kdl1.4  1.4.0-7+b1
ii  libpython3.7      3.7.3-2+deb10u1
ii  libstdc++6        8.3.0-6
ii  python3           3.7.3-1
ii  python3-sip       4.19.14+dfsg-2

python3-pykdl recommends no packages.

python3-pykdl suggests no packages.

-- no debconf information
Index: orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip
===================================================================
--- orocos-kdl-1.4.0.orig/python_orocos_kdl/PyKDL/std_string.sip
+++ orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip
@@ -48,9 +48,7 @@
          return 1;
      }
      if (PyUnicode_Check(sipPy)) {
-        PyObject* s = PyUnicode_AsEncodedString(sipPy, "UTF-8", "");
-        *sipCppPtr = new std::string(PyUnicode_AS_DATA(s));
-        Py_DECREF(s);
+        *sipCppPtr = new std::string(PyUnicode_AsUTF8(sipPy));
         return 1;
      }
 #if PY_MAJOR_VERSION < 3

--- End Message ---
--- Begin Message ---
Source: orocos-kdl
Source-Version: 1.4.0-9
Done: Jochen Sprickerhof <[email protected]>

We believe that the bug you reported is fixed in the latest version of
orocos-kdl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jochen Sprickerhof <[email protected]> (supplier of updated orocos-kdl 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 09 Apr 2020 16:36:15 +0200
Source: orocos-kdl
Architecture: source
Version: 1.4.0-9
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<[email protected]>
Changed-By: Jochen Sprickerhof <[email protected]>
Closes: 956254
Changes:
 orocos-kdl (1.4.0-9) unstable; urgency=medium
 .
   * add Salsa CI
   * Add patch for python3 std string conversion (Closes: #956254)
Checksums-Sha1:
 79ae5df0649401503ac912b0cd81d23b683ca9bc 2303 orocos-kdl_1.4.0-9.dsc
 c016876516088830cdeb6c3e3c66a096855940e0 6772 orocos-kdl_1.4.0-9.debian.tar.xz
 bbd0fcd9007fd69b0fd032f8d6b29cd4be735d4c 6834 
orocos-kdl_1.4.0-9_source.buildinfo
Checksums-Sha256:
 84f1922136dbf573d13604039f1a3c5c4541bc38b55ea37893848df6669d0406 2303 
orocos-kdl_1.4.0-9.dsc
 66656ca23adb853abde9b911cd5a4e137ff2f49fe825f74c6e25da891f727a9e 6772 
orocos-kdl_1.4.0-9.debian.tar.xz
 6cb1ded09cf91ce6c08371d6a3c73b08451d136b4fff1a376e10319c0a47019b 6834 
orocos-kdl_1.4.0-9_source.buildinfo
Files:
 89490544401fce718ba6baa332d181f0 2303 libs optional orocos-kdl_1.4.0-9.dsc
 3e8486b5ec0716104c1e8828d6c09a30 6772 libs optional 
orocos-kdl_1.4.0-9.debian.tar.xz
 d048853a81c97248433ec77c31825d78 6834 libs optional 
orocos-kdl_1.4.0-9_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc7KZy9TurdzAF+h6W//cwljmlDMFAl6PMwUACgkQW//cwljm
lDMBrw//WuNe+FcunIVV6zr7Lq6OnbOHWZdMnVMopcTWIM3io9+UA6L3fNFE6cig
UdE3k7qV43Gdxet/ykQjvNrT6xIPGTzzPxZY/8v8Ai3CsxqEUuZkuYa7un4hBA77
CFsCM7hl9Vsr2tbEKQygabDQKtzyuQsMUzrBmUJFUrp4uJnKCq5JgtI+EJXWuq13
0I3Z57gGQI4OWNEk9UuG4V9v4UnMYidLMz9oWQfNb6ve7S0Ck5c+KLnqLXp+Z414
8YRjFEZAvw15hMpT7eW5ixcGcCxUjT6HzgQVBqHaOLbC4ssfp7yrJWFutXx7o6sI
lwg4u3gPYhP2WZtuyp1baeEoI/gX+ZS9h6O/TH73w79MI14xcUAM8Kvry3275hUT
mcnzxp/faA3Gcdz0kUbQ5e9fRvftNgEp+y/LiBJunP3CqTredPKhVyBh8qirjFTg
EUi5dT9up/2Utmgn3ssuLF2IRvzl/vtSFjSVKXeZ0upyWvUbGsD4D77eCr77EYXB
QA/jgxiU5ZcVi59zg57Q2p8T/oBvezZg8kuSstIqddACojcpOVHKWLIhKlvQYTW7
Y8v3UBRN1YDxMbDs9s105u1D14tuMkT6Nv9lRlmfCevwA7eMUPE3mhLr2EYE9gdB
gWkcTXCESqQjxSyCRG9WVLEXF3ldUQt14gPRCrRu5CLAA2K5NUI=
=tS+G
-----END PGP SIGNATURE-----

--- End Message ---
-- 
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to