Your message dated Sat, 18 Apr 2020 11:17:08 +0000
with message-id <[email protected]>
and subject line Bug#956254: fixed in orocos-kdl 1.4.0-7+deb10u1
has caused the Debian Bug report #956254,
regarding python3-pykdl: PyKDL crashes Python 3 interpretter (SIGABRT) if any 
API accepting a str is used
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
956254: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956254
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python3-pykdl
Version: 1.4.0-7
Severity: important
Tags: patch

Dear Maintainer,


The package python3-pykdl crashes the Python 3 interpretter if any API
accepting a str is used. I've tested this in both Debian Buster and Sid.

$ python3 -c "import PyKDL; PyKDL.Tree('foobar')"
python3: 
/build/orocos-kdl-oHbJfL/orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip:52:
 int convertTo_std_string(PyObject*, void**, int*, PyObject*): Assertion 
`PyUnicode_Check(s)' failed.
Aborted (core dumped)
$ echo $?
134

The following patch resolves the issue on both Buster (1.4.0-7) and Sid
(1.4.0-8)


Index: orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip
===================================================================
--- orocos-kdl-1.4.0.orig/python_orocos_kdl/PyKDL/std_string.sip
+++ orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip
@@ -48,9 +48,7 @@
          return 1;
      }
      if (PyUnicode_Check(sipPy)) {
-        PyObject* s = PyUnicode_AsEncodedString(sipPy, "UTF-8", "");
-        *sipCppPtr = new std::string(PyUnicode_AS_DATA(s));
-        Py_DECREF(s);
+        *sipCppPtr = new std::string(PyUnicode_AsUTF8(sipPy));
         return 1;
      }
 #if PY_MAJOR_VERSION < 3


Would you be willing to apply that patch and release a new version to
Buster and Sid?


Cheers,
Shane


-- System Information:
Debian Release: 10.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.3.0-45-generic (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages python3-pykdl depends on:
ii  libc6             2.28-10
ii  libgcc1           1:8.3.0-6
ii  liborocos-kdl1.4  1.4.0-7+b1
ii  libpython3.7      3.7.3-2+deb10u1
ii  libstdc++6        8.3.0-6
ii  python3           3.7.3-1
ii  python3-sip       4.19.14+dfsg-2

python3-pykdl recommends no packages.

python3-pykdl suggests no packages.

-- no debconf information
Index: orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip
===================================================================
--- orocos-kdl-1.4.0.orig/python_orocos_kdl/PyKDL/std_string.sip
+++ orocos-kdl-1.4.0/python_orocos_kdl/PyKDL/std_string.sip
@@ -48,9 +48,7 @@
          return 1;
      }
      if (PyUnicode_Check(sipPy)) {
-        PyObject* s = PyUnicode_AsEncodedString(sipPy, "UTF-8", "");
-        *sipCppPtr = new std::string(PyUnicode_AS_DATA(s));
-        Py_DECREF(s);
+        *sipCppPtr = new std::string(PyUnicode_AsUTF8(sipPy));
         return 1;
      }
 #if PY_MAJOR_VERSION < 3

--- End Message ---
--- Begin Message ---
Source: orocos-kdl
Source-Version: 1.4.0-7+deb10u1
Done: Jochen Sprickerhof <[email protected]>

We believe that the bug you reported is fixed in the latest version of
orocos-kdl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jochen Sprickerhof <[email protected]> (supplier of updated orocos-kdl 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 09 Apr 2020 18:46:55 +0200
Source: orocos-kdl
Architecture: source
Version: 1.4.0-7+deb10u1
Distribution: buster
Urgency: medium
Maintainer: Debian Science Maintainers 
<[email protected]>
Changed-By: Jochen Sprickerhof <[email protected]>
Closes: 956254
Changes:
 orocos-kdl (1.4.0-7+deb10u1) buster; urgency=medium
 .
   * Add patch for python3 std string conversion (Closes: #956254)
Checksums-Sha1:
 53a8659a4efa9db1d68ab1e46bd9687bc13b2d19 2325 orocos-kdl_1.4.0-7+deb10u1.dsc
 07ce73a84c12d5804207e97480f69b4f6e730d2a 6432 
orocos-kdl_1.4.0-7+deb10u1.debian.tar.xz
 a476cc580304386331ec30006f07b66def9e086d 7534 
orocos-kdl_1.4.0-7+deb10u1_source.buildinfo
Checksums-Sha256:
 cd655ff8b0f0d38464ed79f54dfc62c42b52028e72672f97ad8e9afee8a26792 2325 
orocos-kdl_1.4.0-7+deb10u1.dsc
 0e654874ab022e423d33ce9dc47bd4165ead611c734c077c149c037adfcc1b34 6432 
orocos-kdl_1.4.0-7+deb10u1.debian.tar.xz
 b97c74290f95d02d7ceb34889e84f70f0db159f4b36cf6449636ba0ddd37d20a 7534 
orocos-kdl_1.4.0-7+deb10u1_source.buildinfo
Files:
 3d0e7762103989c22e095ebd0ca8829b 2325 libs optional 
orocos-kdl_1.4.0-7+deb10u1.dsc
 895e6893988c1a2fd93c440166a91fc9 6432 libs optional 
orocos-kdl_1.4.0-7+deb10u1.debian.tar.xz
 5c61d46c16d6fa86dacd33d6cd498ea0 7534 libs optional 
orocos-kdl_1.4.0-7+deb10u1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc7KZy9TurdzAF+h6W//cwljmlDMFAl6TkkwACgkQW//cwljm
lDPgIw//RyNUI0xslB7LNDMCg/qY977bqwPrytBCqk06lMjPU3wk707WeB3mniuU
CIl0ptLc2oOpd9OMezhWBZIfxIP8r2W9dluBn4420p02VG2dNO8AzcYupjCuDZWv
cICglfNLmAP4WDfFxlpGMHSafSbyIGgeR13tVgweAE/vyT1YU7k3jpHNexgTt1K0
+EiDwPi2AYfX8Zg3uzJBXTKU3ykF7XDLli3MUIUvy5BLcrsxg8wXZRCQALi56EQ7
5i/9Sw4eb8OreIzMNiqsy/GbB3LKu5mCgMXxC0uLQ1r96Nu0ynCnsMvYOrBEDzbQ
52G8b/BSSMMfqMjhZ7JGj5oGhWjCmLXqsAoczZv8UIbG93v+k8wWzMllY8YXHXQ9
2OXc2YGmC3mZgn6pcG5knJWrFi50KG6oLn/Lo4HGpEnNkRlOjR6tv4CE+gsYvZSA
b2YcHPh7h6ubcXzXuG8FQcZnLKfNTiIyYDw2/fFnkn61xRgz4E7huUxNHSYN90u9
x3hC6U32aSBrFhvbKUxeml+vCyT7YRcIzPyA8o0uiBQsrC+jZgFN1zx6aywP47gF
5JymwQ6HJ285CeSgjmarURUq0YFpAWUnRnh1gpx/AV4U2lFqsCPmP91FCok29fQG
H/rTTwkctrUMknfiAqPp6IRNSFbcE6ROnEhKQjUOIEIfiR8GwAI=
=WAeC
-----END PGP SIGNATURE-----

--- End Message ---
-- 
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to