Dear Andreas, Gianfranco I used some free time to try to kill all issues. There is a brand new toulbar2.git repository on alioth. I list all the things I did below.
First Andreas: > $ lintian toulbar2_0.9.8-1_amd64.changes > I: toulbar2 source: vcs-field-uses-insecure-uri vcs-git > git://anonscm.debian.org/debian-science/packages/toulbar2.git Corrected. > I: toulbar2 source: vcs-field-uses-insecure-uri vcs-browser > http://anonscm.debian.org/gitweb/?p=debian-science/packages/toulbar2.git Corrected. > I: toulbar2 source: quilt-patch-missing-description > 010-inhibit-version-generation A description has been added. > I: toulbar2 source: debian-watch-file-is-missing Nothing done. > W: toulbar2-dbgsym: debug-file-with-no-debug-symbols > usr/lib/debug/.build-id/63/769cbd8ba978f09766bcd677a4c0036429d701.debug Couldn't find a trace of this file. > I: toulbar2: spelling-error-in-binary usr/bin/toulbar2 egde edge Corrected. Amazing what lintian can find ! > I: toulbar2: hardening-no-fortify-functions usr/bin/toulbar2 Nothing done. > W: toulbar2: debian-changelog-has-wrong-weekday 2015-03-25 is a Wednesday Corrected. > W: toulbar2: new-package-should-close-itp-bug Corrected. > E: toulbar2: possible-missing-colon-in-closes Closes Bug#780516 Corrected. > W: toulbar2: debian-changelog-line-too-long line 4 Corrected. > W: toulbar2: description-synopsis-starts-with-article Corrected. > I: toulbar2: description-synopsis-might-not-be-phrased-properly Corrected. > W: toulbar2: binary-without-manpage usr/bin/toulbar2 Corrected. Yeh... I learnt a few principles of nroff :-/ > I: toulbar2: possible-documentation-but-no-doc-base-registration Nothing done. Now for Gianfranco, > control: owner -1 ! > control: tags -1 moreinfo Didn't get these two. I looked for owner and tags fields in debian/control and could not find any. > Hi, lets review! > > rules: > >> -DCMAKE_BUILD_TYPE:STRING=Release > please RelWithDebInfo here I prefer to stick to Release mode. RelWithDebInfo compiles with -O2 -g and is roughly 2% slower than Release (-O3). Yes, it's not big but it's guaranteed. A debugging version is easy to compile for those who want. >> override_dh_auto_test: > # Don't run CTest > please explain Explanation added. Basically, we do the tests before releasing and the tests (which may be long) include a timeout that will fail on slow machines (eg. on a 2GHz ARMv7 Cortex M15). Would need to change the testing logic to remove the timeout and I prefer not to. > changelog: >> Bug#780516 > syntax error. bug: #780516 is right Corrected to the shortest form. > control: > priority -> optional Corrected. >> Vcs-Git: git://anonscm.debian.org/debian-science/packages/toulbar2.git >> Vcs-Browser: >> http://anonscm.debian.org/gitweb/?p=debian-science/packages/toulbar2.git Corrected. >> Standards-Version: 3.9.6 > 3.9.7 now Corrected. >> Architecture: amd64 i386 > why? Changed to Any after tests on other architectures (which detected a -- now corrected -- non portability issue generated by wchar_t being signed on some machines and unsigned on others). > copyright: please convert in machine-readable format 1.0 > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ > (mostly done, but some bits are missing) Should be hopefully Ok now. > Copyright (c) 2008 Olivier ROUSSEL (olivier.roussel <at> cril.univ-artois.fr > not mentioned in copyright file. Now included. > missing licenses: > src/SimpleGlob.h: *No copyright* MIT/X11 (BSD like) Added. > I don't expect everything to be fixed, but please check my review and comment > on the above points. > I didn't check lintian or to run the package, I'll do as soon as the above is > addressed/commented. Thanks a lot for your help. Now waiting for your feedback, guys :-) Best regards, Thomas
