Dear Andreas, Dear Gianfranco, Quick feedback on your comments: > > On Fri, May 06, 2016 at 10:43:08AM +0000, Gianfranco Costamagna wrote:
>> there is an extra space in VCS-fields, triggering a lintian warning Andreas took care of this for me (thanks). >>>> W: toulbar2-dbgsym: debug-file-with-no-debug-symbols >>>> usr/lib/debug/.build-id/63/769cbd8ba978f09766bcd677a4c0036429d701.debug >>> Couldn't find a trace of this file. >> you need to build with RelWithDebInfo to avoid that issue. Ok, compiled with RelWithDebInfo, enforcing -03 >> also please try to enable hardening >> export DEB_BUILD_MAINT_OPTIONS = hardening=+all Tested. Does not compile with this flag set. >> http://debomatic-amd64.debian.net/distribution#unstable/toulbar2/0.9.8-1/lintian >> update std-version to 3.9.8 Andreas did it for me again :-) >> regenerate doxygen documentation at build time Done. >>> I prefer to stick to Release mode. RelWithDebInfo compiles with -O2 -g >>> and is roughly 2% slower than Release (-O3). Yes, it's not big but it's >>> guaranteed. A debugging version is easy to compile for those who want. >> >> ok, up to you then. >> (You might try to build with -O3 -g, but I'm really not sure about what you >> will >> have there!) feel free to experiment and report back. -O3 -g tried and approved. >>> Explanation added. Basically, we do the tests before releasing and the >>> tests (which may be long) include a timeout that will fail on slow >>> machines (eg. on a 2GHz ARMv7 Cortex M15). Would need to change the >>> testing logic to remove the timeout and I prefer not to. >> >> you might want to exclude some test on some architectures, having a >> testsuite is good, because >> it might fail on other debian derivatives (e.g. Ubuntu), where a different >> toolchain/flags >> are used. The tests are done at compile time now. >> I'm not asking about a 10 hours testsuite, but a few tests are indeed >> something we like >>>> copyright: >>> Should be hopefully Ok now. >> >> >> not completely >> P: toulbar2 source: unversioned-copyright-format-uri >> http://dep.debian.net/deps/dep5 >> >> the url is not correct (please look at debomatic to find the correct link) Corrected. >> >> please add a watch file: >> https://wiki.debian.org/debian/watch >> (if possible) Done. >> let me know when you have a new package >> (and please don't override the git history, if you want to have a clean >> history, you can recreate the git repo >> once the package gets accepted if you want) git history unerased. Thanks again to both of you. Thomas
