Thanks a lot for the review.
Am Sat, Oct 05, 2024 at 08:51:35PM +0200 schrieb Pierre Gruet:
Le 05/10/2024 à 15:17, Markus Blatt a écrit :
Thanks a lot for updating alberta!
Would be cool if somebody else would sponsor my changes. If I need to
make more changes to the package then please tell me so.
I reviewed the package and have some questions/remarks. Only the
first ont /has/ to be addressed before uploading to NEW.
- some copyright holders are missing:
$ grep -r "Copyright" ./* | grep -v -e "debian"
shows the names of Universitaet Freiburg, Universitaet Bonn, Hiroshi
Nakashima, Markus Kohm, Radical Eye Software. Could you please
update thoroughly d/copyright?
Uni Bonn is below add_ons/grape which is deactivated for Debian with
--without-grape.
Kohm Nakashima and Radical Eye have copyright in doc. That is also not part
of any binary package currently.
Hence I think copyright is actually fine.
- Following Lintian: no need to set DEB_HOST_ARCH in d/rules,
including /usr/share/dpkg/architecture.mk is enough
- d/libalberta5.lintian-overrides can now be removed, it overrides nothing.
Done.
- Do you know why the Salsa repo holds only the debian/ directory
and not the whole source?
I am not sure. Maybe for historical reasons, e.g. when packaging started
upstream might not have used git yet, but packaging did.
Do think we should change that and move e.g. to the git-buildpackage approach?
I have pushed my changes to salsa
[1] https://salsa.debian.org/science-team/alberta
If I need to do more then please let me know.
Thanks a again for investing the time to sponsor this.
Best,
Markus
--
Dr. Markus Blatt - HPC-Simulation-Software & Services http://www.dr-blatt.de
Pedettistr. 38, 85072 Eichstätt, Germany, USt-Id: DE279960836
Tel.: +49 (0) 160 97590858
